Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Linux/MdnsImpl use System::Layer timer #9537

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

kpschoedel
Copy link
Contributor

Problem

Linux/MdnsImpl currently uses ad-hoc coupling with the POSIX I/O event
loop, which intrudes on and constrains the latter's implementation.

Change overview

Replace the GetMdnsTimeout()/HandleMdnsTimeout() pair with a
System::Layer timer tracking the earliest mDNS timeout.

The last remnants of the Old Republic select() have been swept away.

Testing

Existing unit test TestMdns

#### Problem

Linux/MdnsImpl currently uses ad-hoc coupling with the POSIX I/O event
loop, which intrudes on and constrains the latter's implementation.

#### Change overview

Replace the `GetMdnsTimeout()`/`HandleMdnsTimeout()` pair with a
`System::Layer` timer tracking the earliest mDNS timeout.

The last remnants of ~the Old Republic~ `select()` have been swept away.

#### Testing

Existing unit test TestMdns
@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Size increase report for "esp32-example-build" from 3a50501

File Section File VM
chip-temperature-measurement-app.elf .flash.text 32 32
chip-shell.elf .flash.text -48 -48
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,48
.flash.text,-48,-48

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 016b1d5 into project-chip:master Sep 13, 2021
@kpschoedel kpschoedel deleted the x7725-linux-mdns branch October 4, 2021 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants