[nrfconnect] Enable logger synchronization #9457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nRF Connect examples use the minimal logger mode which uses printk() under the hood. Enable synchronization in printk() so that logs witten from multiple threads don't interfere with each other.
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
LuDuda
approved these changes
Sep 3, 2021
andy31415
approved these changes
Sep 3, 2021
saurabhst
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
nRF Connect examples use the minimal logger mode which uses printk() under the hood. printk() is not synchronized so logs printed from multiple thread can be badly formatted.
Change overview
Enable synchronization in printk() so that logs printed from multiple threads don't interfere with each other.
Testing
Tested manually with nRF Connect examples.