-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32-H2: add platform support for Thread end device #9453
ESP32-H2: add platform support for Thread end device #9453
Conversation
a3d335a
to
68541c5
Compare
68541c5
to
5a9e916
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double verify that the change won't break any functionality of ESP32 and ESP32-C3 as Wi-Fi end devices.
573d129
to
64ebb8a
Compare
802d109
to
feb68aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the code to not #ifdef
large amount of code. We had this in the system and inet layer and are suffering because of this.
@andy31415 The ESP32-H2 IDF branch for Matter is not public yet, this PR mainly aims to enable Espressif's Thread platform support, the ESP32-H2 examples will be supported later when its IDF branch is public. By merging this PR, it helps to unblock our internal development process, that we can develop both Wi-Fi and Thread Matter devices software on the same code base. |
My take on this is that we deny any platforms/versions that cannot be compiled by CHIP developers and CI (if we desire) without any need of special configurations/separate downloads/signing NDAs or similar hurdles. In this case, since this is an unreleased product, CHIP developers cannot compile it without having access to a private/restricted SDK build. This makes it unsuitable for mainline CHIP build. If you have access to some 'beta' SDK and can place that under the vscode (and/or esp32 version) we can reevaluate. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@andy31415 it looks like this compiles happily, but supports upcoming development. @wqx6 can you fix the merge conflicts here? |
At some point we may want to make build_examples.py also support the new board type. |
8edbaa3
to
fa47678
Compare
Size increase report for "esp32-example-build" from 37a6d27
Full report output
|
Problem
Add platform support for Thread end device on ESP32-H2, the new BLE/15.4 combo SoC from Espressif.
Change overview
Add Thread stack in esp32 platform for our 15.4 chip ESP32-H2.
Testing
Test with ESP32-H2