Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTA Requestor Attributes to example apps #9446

Merged
merged 9 commits into from
Sep 14, 2021

Conversation

holbrookt
Copy link
Contributor

Problem

  • OTA Requestor attributes were set as client side when spec says they should be server side
  • neither chip-tool nor all-clusters-app supported these attributes

Change overview

  • fix OTA Requestor attribute definitions
  • add OTA Requestor cluster and attributes to chip-tool and all-clusters-app

Testing

Run

out/debug/chip-tool otasoftwareupdaterequestor write default-ota-provider abc 0

then

out/debug/chip-tool otasoftwareupdaterequestor read default-ota-provider 0

confirm:

[1630628107.788178][155351:155356] CHIP:TOO: OctetString attribute Response: 616263

(note that attribute is interpreted as ASCII)

@github-actions
Copy link

github-actions bot commented Sep 8, 2021

Size increase report for "esp32-example-build" from cb5d39e

File Section File VM
chip-all-clusters-app.elf .flash.rodata 80 80
chip-all-clusters-app.elf .dram0.bss 0 16
chip-all-clusters-app.elf .flash.text 8 8
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,406
.debug_str,0,350
.debug_loc,0,210
.debug_line,0,133
.flash.rodata,80,80
.debug_frame,0,60
.strtab,0,58
.debug_aranges,0,16
.debug_ranges,0,16
.dram0.bss,16,0
.symtab,0,16
.flash.text,8,8
.shstrtab,0,-2
.riscv.attributes,0,-3
[Unmapped],0,-88

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,392
.debug_str,0,237
.debug_line,0,135
.debug_loc,0,88
.debug_frame,0,48
.debug_aranges,0,16
.debug_ranges,0,16

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,329
.debug_str,0,241
.debug_line,0,135
.debug_loc,0,95
.debug_frame,0,48
.debug_aranges,0,16
.debug_ranges,0,16

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,329
.debug_str,0,241
.debug_line,0,135
.debug_loc,0,95
.debug_frame,0,48
.debug_aranges,0,16
.debug_ranges,0,16

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit 0859980 into project-chip:master Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants