Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TV app] Enable missing client callbacks #9359

Conversation

lazarkov
Copy link
Contributor

@lazarkov lazarkov commented Aug 31, 2021

Problem

  • TV example app does not have client callbacks needed for commissioning
  • After callbacks were added, build failed because of unused variable kByteSpanSizeLengthInBytes = 2;

Change overview

  • Updated tv.zap to include client callbacks
  • Updated CHIPClientCallbacks-src.zapt and marked kByteSpanSizeLengthInBytes variable as maybe used
  • Run zap_regen.sh to generate zzz_generated code

Testing

  • Run the ./scripts/tests/test_suites.sh -a tv

@boring-cyborg boring-cyborg bot added the app label Aug 31, 2021
@lazarkov lazarkov force-pushed the feature/add-tv-app-commissioning-callbacks branch from 3fd8160 to cdafeea Compare August 31, 2021 17:59
@github-actions
Copy link

Size increase report for "esp32-example-build" from 3fbd637

File Section File VM
chip-temperature-measurement-app.elf .flash.text -36 -36
chip-lock-app.elf .flash.text 68 68
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,36
.flash.text,-36,-36

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,68,68
[Unmapped],0,-68

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize


@lazarkov lazarkov marked this pull request as ready for review August 31, 2021 20:58
Copy link
Contributor

@chrisdecenzo chrisdecenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like standard zap auto-get

@woody-apple
Copy link
Contributor

@saurabhst ?

@woody-apple woody-apple merged commit 49daa7f into project-chip:master Sep 1, 2021
@lazarkov lazarkov deleted the feature/add-tv-app-commissioning-callbacks branch September 1, 2021 05:23
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Sep 24, 2021
* Enable missing client callbacks

* Update template to exclude unused kByteSpanSizeLengthInBytes variable

* Adding new zap generated files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants