Cleanup IM read #9305
Merged
Cleanup IM read #9305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
requested review from
mspang,
andy31415,
msandstedt,
yufengwangca,
woody-apple and
jmartinez-silabs
yunhanw-google
force-pushed
the
feature/refactor_read_parameter
branch
from
58c5118 to
e40bbb5
Compare
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
LuDuda and
selissia
msandstedt
approved these changes
Aug 28, 2021
saurabhst
approved these changes
Aug 28, 2021
yufengwangca
approved these changes
Aug 30, 2021
andy31415
approved these changes
Aug 30, 2021
yunhanw-google
force-pushed
the
feature/refactor_read_parameter
branch
from
e40bbb5 to
8e5d100
Compare
yunhanw-google
force-pushed
the
feature/refactor_read_parameter
branch
3 times, most recently
from
b3c5382 to
4f60951
Compare
jmartinez-silabs
approved these changes
Aug 30, 2021
|
/rebase |
Summary of Changes: -- SendReadRequest takes too many parameters, we need to add one structure to pack those paramters.
woody-apple
force-pushed
the
feature/refactor_read_parameter
branch
from
4f60951 to
b90f613
Compare
mkardous-silabs
pushed a commit
to mkardous-silabs/connectedhomeip
that referenced
this pull request
Sep 24, 2021
Summary of Changes: -- SendReadRequest takes too many parameters, we need to add one structure to pack those paramters.
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
May 11, 2023
Parameter lists were replaced with a structure since project-chip#9305
Merged
woody-apple
pushed a commit
that referenced
this pull request
May 11, 2023
Parameter lists were replaced with a structure since #9305
tcarmelveilleux
added a commit
to tcarmelveilleux/connectedhomeip
that referenced
this pull request
Jul 9, 2024
- Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in attribute and command numbering. - Introduce maturity level to everything.
lazarkov
pushed a commit
to lazarkov/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…34261) - Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in attribute and command numbering. - Introduce maturity level to everything.
austina-csa
pushed a commit
to austina-csa/connectedhomeip
that referenced
this pull request
Jul 10, 2024
…34261) - Address spec PRs project-chip#9305/project-chip#9401 re: removing gaps in attribute and command numbering. - Introduce maturity level to everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
-- SendReadRequest takes too many parameters, we need to add one
structure to pack those parameters in IM read
Change overview
Add ReadPrepareParams to pack the parameters for IM read
Testing
The existing test covers.