-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix operational credentials fabric count attributes #9303
Fix operational credentials fabric count attributes #9303
Conversation
53cb111
to
9fc6907
Compare
@andy31415 , @Damian-Nordic , @jepenven-silabs do you have any review feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Test must be written to avoid assumption which is a configuration option of the project rather than a well-known constant.
5c5a056
to
68ddc93
Compare
rebased.. trying to re-trigger CI. |
68ddc93
to
1e5e61b
Compare
Size increase report for "gn_qpg-example-build" from a5569db
Full report output
|
Size increase report for "esp32-example-build" from a5569db
Full report output
|
Size increase report for "nrfconnect-example-build" from a5569db
Full report output
|
@andy31415 , @Damian-Nordic , @jepenven-silabs do you have any review feedback? |
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
I did a manual merge of this - the change seemed to be only the test list. |
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
* Fix operational credentials fabric count attributes * make the PR independet of compressed fabric ID feature * add test to Darwin tests as well * remove invalid check for vendor id * Update unit tests to check for limits * update number of min fabrics in the test * remove upper limit check in SupportedFabrics
Problem
The
SupportedFabrics
andCommissionedFabrics
attributes of operational credentials cluster are always 0, when accessed via the read attribute command.Change overview
The attribute values were not getting updated. The code to write
SupportedFabrics
was missing.CommissionedFabrics
value was not written due to FabricID check.Testing
Added a new cluster test to read and verify these two values.