Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move controller data to zzz_generated #9280

Merged
merged 13 commits into from
Aug 30, 2021

Conversation

andy31415
Copy link
Contributor

Problem

Standardize to have zzz_generated for generated outputs, to make layering and dependencies obvious and code reviews easier.

Change overview

moves src/controller/data_model generated files into zzz_generated

Testing

Local compilation tests, CI will also validate that compilation still works.

@todo
Copy link

todo bot commented Aug 26, 2021

this should be a dependency on src/controller/data_model however this is circular:

# TODO: this should be a dependency on src/controller/data_model however this is circular:
# zzz_generated/controller-clusters depend on src/controller
# src/controller neeeds zzz_generated/controller-cluster for includes
include_dirs = [ "${chip_root}/zzz_generated/" ]
}
static_library("controller") {
output_name = "libChipController"


This comment was generated by todo based on a TODO comment in a4792a7 in #9280. cc @andy31415.

Copy link
Contributor

@jmeg-sfy jmeg-sfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like to be the final one .. yeah !!!

@andy31415
Copy link
Contributor Author

Looks like to be the final one .. yeah !!!

CPP I think it may be. We still have java & python & objectivec beyond that.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 488a3b0

File Section File VM
chip-bridge-app.elf .flash.text 48 48
chip-bridge-app.elf .iram0.text 4 4
chip-temperature-measurement-app.elf .iram0.text 4 4
chip-shell.elf .flash.text 56 56
chip-lock-app.elf .flash.text 68 68
chip-lock-app.elf .iram0.text 4 4
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,1555
.debug_str,0,891
.debug_line,0,561
.debug_frame,0,72
.debug_ranges,0,48
.flash.text,48,48
.debug_abbrev,0,26
.debug_aranges,0,24
.iram0.text,4,4
.debug_loc,0,3
[Unmapped],0,-52

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,1555
.debug_str,0,893
.debug_line,0,551
.debug_loc,0,363
.debug_frame,0,72
.debug_ranges,0,48
.debug_abbrev,0,26
.debug_aranges,0,24
.iram0.text,4,4
[Unmapped],0,-4

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,1340
.debug_str,0,892
.debug_line,0,415
.debug_frame,0,100
.debug_loc,0,58
.debug_ranges,0,48
.debug_abbrev,0,26
.debug_aranges,0,24
.riscv.attributes,0,1

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,1555
.debug_str,0,883
.debug_line,0,561
.debug_loc,0,267
.debug_frame,0,72
.flash.text,56,56
.debug_ranges,0,48
.debug_abbrev,0,26
.debug_aranges,0,24
[Unmapped],0,-56

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,1555
.debug_str,0,891
.debug_line,0,561
.debug_loc,0,219
.debug_frame,0,72
.flash.text,68,68
.debug_ranges,0,48
.debug_abbrev,0,26
.debug_aranges,0,24
.iram0.text,4,4
[Unmapped],0,-72


@andy31415
Copy link
Contributor Author

@andy31415 andy31415 merged commit 62165b1 into project-chip:master Aug 30, 2021
mkardous-silabs pushed a commit to mkardous-silabs/connectedhomeip that referenced this pull request Sep 24, 2021
* Move src_controller/data_model generated files to zzz_generated

* Another chipclusters update for lighting app. This seems unstable somehow

* more lighting updates ... again

* Ran another regen

* Rename again, to make relative paths clearer

* Rename back for consistency, make build paths work (in theory)

* Propagate the controller config for includes - controller includes require the zzz_generated includes

* Restyle fixes

* update regen script and regen all

* Regen all ... again

* update include paths for darwin build (relative zap generated include is still odd in util)
@andy31415 andy31415 deleted the move_controller_data_to_zzz branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants