-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move controller data to zzz_generated #9280
Move controller data to zzz_generated #9280
Conversation
…quire the zzz_generated includes
this should be a dependency on src/controller/data_model however this is circular:connectedhomeip/src/controller/BUILD.gn Lines 18 to 27 in a4792a7
This comment was generated by todo based on a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like to be the final one .. yeah !!!
CPP I think it may be. We still have java & python & objectivec beyond that. |
Size increase report for "esp32-example-build" from 488a3b0
Full report output
|
… is still odd in util)
* Move src_controller/data_model generated files to zzz_generated * Another chipclusters update for lighting app. This seems unstable somehow * more lighting updates ... again * Ran another regen * Rename again, to make relative paths clearer * Rename back for consistency, make build paths work (in theory) * Propagate the controller config for includes - controller includes require the zzz_generated includes * Restyle fixes * update regen script and regen all * Regen all ... again * update include paths for darwin build (relative zap generated include is still odd in util)
Problem
Standardize to have zzz_generated for generated outputs, to make layering and dependencies obvious and code reviews easier.
Change overview
moves src/controller/data_model generated files into zzz_generated
Testing
Local compilation tests, CI will also validate that compilation still works.