Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup legacy profile code inherited from Weave #9188

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Cleanup legacy profile code inherited from Weave #9188

merged 1 commit into from
Aug 24, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Current CHIP codebase has some legacy code inherited from Weave, those codes are not either used or linked.

Change overview

This PR clean up code from Security profile and TimeSync profile, neither of these two profiles have space in CHIP spec.

Testing

How was this tested? (at least one bullet point required)

  • No logic change, just clean up unlinked dead code.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 82cf1b1

File Section File VM
chip-ipv6only-app.elf .flash.text 172 172
chip-temperature-measurement-app.elf .flash.text -60 -60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_loc,0,47
.debug_str,0,-18
.debug_info,0,-679
.debug_line,0,-714

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,172,172
[Unmapped],0,-172

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,44
.riscv.attributes,0,3
.debug_str,0,-16
.debug_info,0,-772
.debug_line,0,-819

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_abbrev,0,-14
.debug_str,0,-16
.debug_loc,0,-51
.debug_info,0,-535
.debug_line,0,-588

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_abbrev,0,-14
.debug_str,0,-18
.debug_loc,0,-33
.debug_info,0,-593
.debug_line,0,-630

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize
.debug_loc,0,6
.debug_str,0,-26
.debug_info,0,-38
.debug_line,0,-42

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,60
.debug_loc,0,47
.debug_str,0,-15
.flash.text,-60,-60
.debug_info,0,-575
.debug_line,0,-609


@saurabhst saurabhst merged commit 948dd7b into project-chip:master Aug 24, 2021
@yufengwangca yufengwangca deleted the pr/profile/cleanup branch August 24, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants