Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add temperature measurement app to the build_examples.py script #9118

Merged

Conversation

andy31415
Copy link
Contributor

@andy31415 andy31415 commented Aug 18, 2021

Problem

Need as much build coverage as possible to build_examples.py

Change overview

Add temperature_measurement app to support compilation (esp32 is the only target for this app currently)

Testing

Compiled via:

./scripts/build/build_examples.py --app temperature-measurement build

Ran compilation via the vscode menu (specific app)
Unit tests pass

@boring-cyborg boring-cyborg bot added the vscode label Aug 18, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from 2418eb7

File Section File VM
chip-bridge-app.elf .flash.text 48 48
chip-shell.elf .flash.text 56 56
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.flash.text,48,48
[Unmapped],0,-48

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,56,56
[Unmapped],0,-56

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize


@woody-apple woody-apple merged commit ab66572 into project-chip:master Aug 21, 2021
sharadb-amazon pushed a commit to sharadb-amazon/connectedhomeip that referenced this pull request Aug 23, 2021
…ect-chip#9118)

* Add temperature measurement app to the build_examples.py script

* Added temperature measurement app to vscode tasks

* Add missing comma in tasks.json list

* Fix unit tests

* Update path to output dir for test purposes

* Add terminating newlines to txt file for unit test

Co-authored-by: Justin Wood <[email protected]>
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…ect-chip#9118)

* Add temperature measurement app to the build_examples.py script

* Added temperature measurement app to vscode tasks

* Add missing comma in tasks.json list

* Fix unit tests

* Update path to output dir for test purposes

* Add terminating newlines to txt file for unit test

Co-authored-by: Justin Wood <[email protected]>
@andy31415 andy31415 deleted the build_temperature_measurement branch October 28, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants