Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cirque repo commit #9104

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

mingchik
Copy link
Contributor

Problem

What is being fixed? Examples:
bump up cirque latest commit

Change overview

cirque latest commit

@andy31415
Copy link
Contributor

I think we merged the latest cirque fairly recently (1 day ago in #9032). Any reason for the frequent change? I would expect 'pull latest repo' to happen on a month+ basis rather than several times a week.

@mspang
Copy link
Contributor

mspang commented Aug 18, 2021

I would expect 'pull latest repo' to happen on a month+ basis rather than several times a week.

Why? I'd say ideally things roll ~daily if they are actively developed (and that there be adequate testing to make sure that works).

We know that more frequent releases is correlated with better execution.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 8273d5d

File Section File VM
chip-lock-app.elf .flash.text -68 -68
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,68
.flash.text,-68,-68


@andy31415
Copy link
Contributor

I would expect 'pull latest repo' to happen on a month+ basis rather than several times a week.

Why? I'd say ideally things roll ~daily if they are actively developed (and that there be adequate testing to make sure that works).

We know that more frequent releases is correlated with better execution.

I have just not seen it update in other places as frequently. If we want frequent syncs, I would try to automate it as PR creation and a separate 3-person review process with sdk approved and technical review done seems really heavy effort.

If we do it infrequently, I don't care about automation as much. For more frequent changes, I would like to script this or at least agree to hotfix/admin merge these.

@yunhanw-google
Copy link
Contributor

i think it is not frequent sync, mingchi just forget to bring one latest change in last sync.

@andy31415 andy31415 merged commit 04e1900 into project-chip:master Aug 19, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants