-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cirque repo commit #9104
update cirque repo commit #9104
Conversation
fb75d60
to
0cc14ab
Compare
I think we merged the latest cirque fairly recently (1 day ago in #9032). Any reason for the frequent change? I would expect 'pull latest repo' to happen on a month+ basis rather than several times a week. |
Why? I'd say ideally things roll ~daily if they are actively developed (and that there be adequate testing to make sure that works). We know that more frequent releases is correlated with better execution. |
Size increase report for "esp32-example-build" from 8273d5d
Full report output
|
I have just not seen it update in other places as frequently. If we want frequent syncs, I would try to automate it as PR creation and a separate 3-person review process with sdk approved and technical review done seems really heavy effort. If we do it infrequently, I don't care about automation as much. For more frequent changes, I would like to script this or at least agree to hotfix/admin merge these. |
i think it is not frequent sync, mingchi just forget to bring one latest change in last sync. |
Problem
What is being fixed? Examples:
bump up cirque latest commit
Change overview
cirque latest commit