-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix discovery issues with minimal mDNS #9102
Merged
mspang
merged 1 commit into
project-chip:master
from
mspang:for-chip/fix-mdns-discovery
Aug 20, 2021
Merged
Fix discovery issues with minimal mDNS #9102
mspang
merged 1 commit into
project-chip:master
from
mspang:for-chip/fix-mdns-discovery
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix this comparison which is too loose.connectedhomeip/src/lib/mdns/Resolver_ImplMinimalMdns.cpp Lines 222 to 232 in 590b5d6
This comment was generated by todo based on a
|
Fix this comparison which is too loose.connectedhomeip/src/lib/mdns/Resolver_ImplMinimalMdns.cpp Lines 230 to 237 in 590b5d6
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
August 18, 2021 02:09
- Don't skip the rest of the packet if it contains an irrelevant resource record. DNS packets can contain records other than those directly requested. - Don't terminate chip-tool commissioning if a device other than the commissionee is discovered. There is nothing preventing receiving OnAddressUpdateComplete for stale records and this will generally happen when doing tests in quick succession because stale records accumulate in the SRP server. fixes project-chip#9099
mspang
force-pushed
the
for-chip/fix-mdns-discovery
branch
from
August 18, 2021 02:10
590b5d6
to
a8d6156
Compare
@cecille Would your testability work help with being able to write a test for this? |
Size increase report for "esp32-example-build" from 303c02c
Full report output
|
andy31415
approved these changes
Aug 18, 2021
woody-apple
approved these changes
Aug 19, 2021
msandstedt
approved these changes
Aug 20, 2021
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 23, 2021
- Don't skip the rest of the packet if it contains an irrelevant resource record. DNS packets can contain records other than those directly requested. - Don't terminate chip-tool commissioning if a device other than the commissionee is discovered. There is nothing preventing receiving OnAddressUpdateComplete for stale records and this will generally happen when doing tests in quick succession because stale records accumulate in the SRP server. fixes project-chip#9099
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
- Don't skip the rest of the packet if it contains an irrelevant resource record. DNS packets can contain records other than those directly requested. - Don't terminate chip-tool commissioning if a device other than the commissionee is discovered. There is nothing preventing receiving OnAddressUpdateComplete for stale records and this will generally happen when doing tests in quick succession because stale records accumulate in the SRP server. fixes project-chip#9099
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Discovering the operational service during commissioning fails with minimal
mDNS in certain environments (e.g. otbr + mdnsresponder).
Change overview
Don't skip the rest of the packet if it contains an irrelevant
resource record. DNS packets can contain records other than
those directly requested.
Don't terminate chip-tool commissioning if a device other than
the commissionee is discovered. There is nothing preventing
receiving OnAddressUpdateComplete for stale records and this
will generally happen when doing tests in quick succession
because stale records accumulate in the SRP server.
Testing
chip-tool pairing ble-thread ex:<dataset-in-base64> 112233 20202021 3840
with Pi + otbr-posix + mdnsresponderfixes #9099