-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Replace static service resolve callback with Java abstraction #9097
Merged
andy31415
merged 1 commit into
project-chip:master
from
austinh0:devicecontroller-interface
Aug 20, 2021
Merged
[Android] Replace static service resolve callback with Java abstraction #9097
andy31415
merged 1 commit into
project-chip:master
from
austinh0:devicecontroller-interface
Aug 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31aa5e5
to
259c4fe
Compare
…in ServiceResolver.
259c4fe
to
e29b5f0
Compare
Size increase report for "esp32-example-build" from 303c02c
Full report output
|
woody-apple
approved these changes
Aug 19, 2021
msandstedt
approved these changes
Aug 20, 2021
saurabhst
approved these changes
Aug 20, 2021
andy31415
approved these changes
Aug 20, 2021
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Aug 23, 2021
…in ServiceResolver. (project-chip#9097)
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…in ServiceResolver. (project-chip#9097)
Merged
xylophone21
added a commit
to xylophone21/connectedhomeip
that referenced
this pull request
Sep 29, 2021
xylophone21
added a commit
to xylophone21/connectedhomeip
that referenced
this pull request
Sep 30, 2021
andy31415
pushed a commit
that referenced
this pull request
Sep 30, 2021
* added android platform impl and CHIPTest to run ul-test on it * add clangd index file and compile_commands.json to .gitignore * use platform/android in src/controller instead of impl themselves * basic run and debug with new control * use inject driver mode as old controller as Andrei Litvin suggestion * fix ci build * fix ci build * fixed restyled-io * fixed restyled-io * fixed Doxygen ci * fixed review code style issues * move AndroidChipPlatform singleton down to the app layer * move dependencies in the constructor for AndroidChipPlatform * using val than var * update gradle version in CHIPTest and fix runtime errors * fixed restyled-io * remove commented out code * fixed restyled-io * update license to 2021 * fixed review code style issues * fix ci build * rename load to loadJni and add a comment describing the purpose. * fixed review code style issues * separate ble callback and Connection * Recovery PR #9097 * fix merge issue * fix merge issue * fixed restyled-io * fixed restyled-io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When Android resolves a service, we call the static
handleServiceResolve
onChipDeviceController.java
.ChipDeviceController.java
Change overview
chip.devicecontroller.mdns
packageChipDeviceController.handleServiceResolve
toChipMdnsCallback
/ChipMdnsCallbackImpl
, with its own-JNI.cpp
fileChipMdnsCallback
instance inChipDeviceController
constructorServiceResolver
provideChipMdnsCallback
as a parameter inresolve()
. This removes the need for a static accessor.Testing