TODOs from PR #6561

[kpschoedel]

Problem

Some TODOs left over from PR #6561.

Change overview

• Remove the temporary PrepareEventsWithTimeout(), which was added in Generalize socket-based event loop #6561 to provide unit tests back-door access to the event loop select() timeout, and have the tests that used it use a normal System::Layer timer instead.
• Remove obsolete TODOs.

Fixes #7760 Some unit tests supply a timeout at low level
Fixes #7756 add a timer for sleepTime.tv_sec = 10; sleepTime.tv_usec = 0;

Testing

Ran the affected tests.

[github-actions]

Size increase report for "nrfconnect-example-build" from 6a36256

File	Section	File	VM
chip-lock.elf	device_handles	-8	-8
chip-lock.elf	text	-56	-56
chip-shell.elf	device_handles	-12	-12
chip-shell.elf	text	-52	-52

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_ranges,0,40
.debug_abbrev,0,35
.shstrtab,0,1
.debug_aranges,0,-8
device_handles,-8,-8
.debug_frame,0,-16
.debug_line,0,-21
text,-56,-56
.symtab,0,-64
.debug_str,0,-100
.strtab,0,-125
.debug_loc,0,-152
.debug_info,0,-2530

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_str,0,315
.debug_ranges,0,40
.debug_abbrev,0,35
.shstrtab,0,1
.debug_aranges,0,-8
device_handles,-12,-12
.debug_frame,0,-16
.debug_line,0,-23
text,-52,-52
.symtab,0,-64
.debug_loc,0,-91
.strtab,0,-125
.debug_info,0,-1276

[github-actions]

Size increase report for "esp32-example-build" from 6a36256

File	Section	File	VM
chip-lock-app.elf	.flash.text	-68	-68
chip-temperature-measurement-app.elf	.flash.text	-60	-60
chip-ipv6only-app.elf	.flash.text	-172	-172
chip-shell.elf	.flash.text	8	8

Full report output

BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,68
.flash.text,-68,-68

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,60
.flash.text,-60,-60

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
[Unmapped],0,172
.flash.text,-172,-172

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,8,8
[Unmapped],0,-8

[kpschoedel]

@Damian-Nordic @hawk248 @jepenven-silabs @msandstedt ?