-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shell] Add "dns browse commissioner" command #8836
Merged
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:commissioner-discovery
Aug 11, 2021
Merged
[shell] Add "dns browse commissioner" command #8836
Damian-Nordic
merged 2 commits into
project-chip:master
from
Damian-Nordic:commissioner-discovery
Aug 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
saurabhst and
woody-apple
August 6, 2021 14:17
jmartinez-silabs
approved these changes
Aug 9, 2021
andy31415
approved these changes
Aug 10, 2021
LuDuda
approved these changes
Aug 10, 2021
saurabhst
approved these changes
Aug 10, 2021
The existing "dns browse" command searches for Matter commissionable nodes only. Split it into "dns browse commissionable" and "dns browse commissioner" to provide means to test commissioner discovery on all devices. Also, allow to specify a subtype for both commands and fix buffer sizes in the OpenThread-based DNS implementation to accomodate filtering by subtypes.
Damian-Nordic
force-pushed
the
commissioner-discovery
branch
from
August 11, 2021 06:19
1f8b551
to
f134908
Compare
Size increase report for "nrfconnect-example-build" from b3f7d9f
Full report output
|
Size increase report for "esp32-example-build" from b3f7d9f
Full report output
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [shell] Add "dns browse commissioner" command The existing "dns browse" command searches for Matter commissionable nodes only. Split it into "dns browse commissionable" and "dns browse commissioner" to provide means to test commissioner discovery on all devices. Also, allow to specify a subtype for both commands and fix buffer sizes in the OpenThread-based DNS implementation to accomodate filtering by subtypes. * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing "dns browse" command searches for Matter commissionable nodes only and we need some way to verify commissioner discovery for TE5.
Change overview
Split "dns browse" command into "dns browse commissionable" and "dns browse commissioner" to provide means to test commissioner discovery on all devices.
Also, allow to specify a subtype for both commands and fix buffer sizes in the OpenThread-based DNS implementation to
accomodate filtering by subtypes.
Testing
Tested manually that commands for both commissionable and commissioner discovery work correctly on nRF52840 DK (although other Thread platforms should behave the same since the code is shared) when the commissionable and commissioner node services are published by other devices in the same Thread network or in the Wi-Fi/Ethernet network that OTBR is connected to. Note that there's an issue in OpenThread with publishing services with subtypes, so the OTBR must be built with the following patch to test this change: openthread/openthread#6901.