-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle Mdns: Allow multiple operational advertisements #8789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved CheckOnlyServer into its own file and created a minimal mdns implementation that uses the CheckOnlyServer - Added a () constructor to the CheckOnlyServer with an option to set the test suite after. - fixed a bug where the truncated flag was not being set properly - Added a function to the response allocator to determine if given ResourceRecord is there - Added a check at the start of operational to check for the given SRV record in the allocator - these records are unique to each fabric / node. If a different fabric/node is identified, the Advertise feature will start a new query responder to append records rather than replacing. - added tests for operational mdns records with single and multiple fabrics.
Zephyr uses a monolothic lib that already links in a version of the mdns library.
Apparently the default is the same as the directory name. TIL. https://gn.googlesource.com/gn/+/main/docs/reference.md#implicit-names
Flat allocator is overkill for a local variable because the individual peices don't go out of scope before the QName.
(cecille): need to better document this value. Why is the comment different than the value?connectedhomeip/src/lib/mdns/minimal/core/DnsHeader.h Lines 80 to 84 in aad0eba
This comment was generated by todo based on a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #8610 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.