Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Mdns: Allow multiple operational advertisements #8789

Closed
wants to merge 13 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Aug 4, 2021

A duplicate of #8610 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

cecille and others added 13 commits July 27, 2021 10:47
- moved CheckOnlyServer into its own file and created a minimal
  mdns implementation that uses the CheckOnlyServer
- Added a () constructor to the CheckOnlyServer with an option
  to set the test suite after.
- fixed a bug where the truncated flag was not being set properly
- Added a function to the response allocator to determine if
  given ResourceRecord is there
- Added a check at the start of operational to check for the given
  SRV record in the allocator - these records are unique to each
  fabric / node. If a different fabric/node is identified, the
  Advertise feature will start a new query responder to append
  records rather than replacing.
- added tests for operational mdns records with single and multiple
  fabrics.
Zephyr uses a monolothic lib that already links in a version of
the mdns library.
Apparently the default is the same as the directory name. TIL.

https://gn.googlesource.com/gn/+/main/docs/reference.md#implicit-names
Flat allocator is overkill for a local variable because the individual
peices don't go out of scope before the QName.
@restyled-io restyled-io bot added the restyled label Aug 4, 2021
@todo
Copy link

todo bot commented Aug 4, 2021

(cecille): need to better document this value. Why is the comment different than the value?

// TODO(cecille): need to better document this value. Why is the comment different than the value?
static constexpr uint16_t kMdnsNonIgnoredMask = 0x8E08;
static constexpr uint16_t kIsResponseMask = 0x8000;
static constexpr uint16_t kOpcodeMask = 0x7000;


This comment was generated by todo based on a TODO comment in aad0eba in #8789. cc @project-chip.

@boring-cyborg boring-cyborg bot added the lib label Aug 4, 2021
@restyled-io restyled-io bot closed this Aug 4, 2021
@restyled-io restyled-io bot deleted the restyled/pull-8610 branch August 4, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants