Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup prefix chip:: from all cluster implementations #8771

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Cleanup prefix chip:: from all cluster implementations #8771

merged 1 commit into from
Aug 5, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

Change overview

Cleanup prefix chip:: from all cluster implementations

Testing

How was this tested? (at least one bullet point required)

  • No logic change, the regression test is covered by CI.

@yufengwangca yufengwangca merged commit 5647deb into project-chip:master Aug 5, 2021
@github-actions
Copy link

github-actions bot commented Aug 5, 2021

Size increase report for "esp32-example-build" from 99ef92e

File Section File VM
chip-temperature-measurement-app.elf .flash.text 60 60
chip-all-clusters-app.elf .flash.text 80 80
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
.debug_info,0,8
.debug_str,0,-1
.debug_line,0,-3
[Unmapped],0,-60

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,80,80
.debug_info,0,58
.debug_str,0,-1
.debug_loc,0,-2
.debug_line,0,-3
[Unmapped],0,-80

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,9
.debug_loc,0,-1
.debug_str,0,-1
.debug_line,0,-3

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-bridge-app.elf and ./pull_artifact/chip-bridge-app.elf:

sections,vmsize,filesize
.debug_info,0,8
.debug_str,0,3
.debug_line,0,-3


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup prefix chip:: from all cluster implementations in which has 'using namespace chip'
5 participants