-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[K32W] Sync button push with cluster state #8761
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
yufengwangca
August 3, 2021 09:03
Damian-Nordic
approved these changes
Aug 3, 2021
Damian-Nordic
approved these changes
Aug 3, 2021
yufengwangca
reviewed
Aug 3, 2021
andy31415
reviewed
Aug 3, 2021
woody-apple
approved these changes
Aug 9, 2021
Why is the "CHIP-PR-upload (matter-build-automation)" failing? I see a message "Needs /gcbrun from a collaborator" but I don't know how to solve it. |
/gcbrun |
/rebase |
If buttons are used for locking/unlocking the elock or for turn off/down of the lighting then this change needs to be propagated to the cluster state. Signed-off-by: Doru Gucea <[email protected]>
If buttons are used for locking/unlocking the elock or for turn off/down of the lighting then this change needs to be propagated to the cluster state. Signed-off-by: Doru Gucea <[email protected]>
Size increase report for "esp32-example-build" from b3f7d9f
Full report output
|
andy31415
approved these changes
Aug 11, 2021
andy31415
approved these changes
Aug 11, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* [K32W] Sync button push with cluster state If buttons are used for locking/unlocking the elock or for turn off/down of the lighting then this change needs to be propagated to the cluster state. Signed-off-by: Doru Gucea <[email protected]> * [K32W] Sync button push with cluster state If buttons are used for locking/unlocking the elock or for turn off/down of the lighting then this change needs to be propagated to the cluster state. Signed-off-by: Doru Gucea <[email protected]> * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If buttons are used for locking/unlocking the elock or for
turn off/down of the lighting then this change needs to be
propagated to the cluster state.
Change overview
Sync the cluster state:
Testing
Manually tested.