Make CHIP_ERROR a class type on Darwin #8738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
sagar-apple,
saurabhst and
woody-apple
mspang
approved these changes
Jul 30, 2021
kpschoedel
approved these changes
Jul 30, 2021
jmartinez-silabs
approved these changes
Aug 2, 2021
andy31415
approved these changes
Aug 3, 2021
|
@woody-apple @Damian-Nordic @saurabhst @msandstedt @LuDuda Please take a look? |
saurabhst
approved these changes
Aug 3, 2021
msandstedt
approved these changes
Aug 3, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
CHIP_ERROR is not a class type on Darwin, so we can't get nice location tracking for errors.
Change overview
Make it a class type.
Testing
Compiled the tree on Darwin. Ran some tests that should log errors and saw that those errors had file/line info.