Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for device side log for EnhancedHue attribute under color control cluster. #8723

Merged
merged 1 commit into from
Jul 30, 2021

Conversation

sweetymhaiske
Copy link
Contributor

Problem

  • Device log displays the old value of Hue attribute when the commands for EnhancedHue attributes are used.
  • Controller command
chip-device-ctrl > zcl ColorControl EnhancedMoveHue 12344321 1 0 moveMode=0 rate=100 optionsMask=0 optionsOverride=0
  • Device side log
I (5656383) chip[ZCL]: Hue 171 Saturation 254 endpoint 1

Change overview

  • Added the fix for the display log.

Testing

  • Build, flash and commissioned all-clusters-app
  • Sent EnhancedHue commands
  • Observed the logs
    Device log
I (124713) chip[ZCL]: Enhanced Hue 910 Saturation 0 endpoint 1

@andy31415 andy31415 merged commit 6fd11d8 into project-chip:master Jul 30, 2021
@github-actions
Copy link

Size increase report for "esp32-example-build" from b6ff63e

File Section File VM
chip-all-clusters-app.elf .flash.rodata 40 40
chip-all-clusters-app.elf .flash.text 24 24
chip-temperature-measurement-app.elf .flash.text 64 64
chip-shell.elf .flash.text 24 24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_line,0,45
.debug_loc,0,41
.flash.rodata,40,40
.flash.text,24,24
.riscv.attributes,0,3
.debug_info,0,-17
[Unmapped],0,-64

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,24,24
[Unmapped],0,-24


rcasallas-silabs pushed a commit to rcasallas-silabs/connectedhomeip that referenced this pull request Aug 2, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants