Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement administrator commissioning cluster #8680

Merged
merged 10 commits into from
Aug 4, 2021
Merged

Implement administrator commissioning cluster #8680

merged 10 commits into from
Aug 4, 2021

Conversation

pan-apple
Copy link
Contributor

Problem

The commands to open commissioning window is not implemented as per spec. The commands are expected to be part of Administrator Commissioning Cluster.

Change overview

Implemented administrator commissioning cluster

Testing

Tested pairing using Python controller, iOS CHIPTool and chip-tool apps.
Tested opening the commissioning window using iOS CHIPTool app.

@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch from 3e93028 to dff1b14 Compare July 28, 2021 16:06
@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch from dff1b14 to 50dc486 Compare July 28, 2021 23:39
@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch 2 times, most recently from 16d3672 to 8a368e0 Compare July 29, 2021 15:26
@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch from 8a368e0 to e7cdccd Compare July 30, 2021 17:33
@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch 3 times, most recently from 1ba64a2 to 7c6b665 Compare August 2, 2021 15:16
@pan-apple
Copy link
Contributor Author

@Damian-Nordic, @jepenven-silabs do you have any review feedback

@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch from 7c6b665 to 6de5d1b Compare August 2, 2021 20:29
@pan-apple pan-apple force-pushed the administrator-commissioning-cluster branch from 2a884cc to 2618857 Compare August 3, 2021 19:32
@pan-apple
Copy link
Contributor Author

rebased

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Size increase report for "gn_qpg-example-build" from 69ae019

File Section File VM
chip-qpg6100-lighting-example.out .text 1008 1008
chip-qpg6100-lighting-example.out .data 4 4
chip-qpg6100-lighting-example.out .heap 0 -8
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,20829
.debug_line,0,5801
.debug_loc,0,3004
.debug_abbrev,0,2610
.debug_str,0,1692
.text,1008,1008
.strtab,0,921
.symtab,0,560
.debug_frame,0,284
.debug_aranges,0,72
[ELF Headers],0,32
.data,4,4
.shstrtab,0,-1
.heap,-8,0
.debug_ranges,0,-112
[Unmapped],0,-1040

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Size increase report for "nrfconnect-example-build" from 69ae019

File Section File VM
chip-lock.elf text 860 860
chip-lock.elf rodata 152 148
chip-lock.elf datas 4 4
chip-lock.elf device_handles 4 4
chip-lock.elf devices 4 4
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,190
.debug_str,0,115
.debug_line,0,-2
.debug_loc,0,-47

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,22848
.debug_line,0,5312
.debug_loc,0,2784
.debug_abbrev,0,2740
.debug_str,0,1672
.strtab,0,921
text,860,860
.symtab,0,608
.debug_frame,0,276
rodata,148,152
.debug_aranges,0,72
datas,4,4
device_handles,4,4
devices,4,4
.shstrtab,0,3
.debug_ranges,0,-112

@github-actions
Copy link

github-actions bot commented Aug 3, 2021

Size increase report for "esp32-example-build" from 69ae019

File Section File VM
chip-temperature-measurement-app.elf .flash.text 972 972
chip-temperature-measurement-app.elf .flash.rodata 224 224
chip-temperature-measurement-app.elf .dram0.bss 0 8
chip-temperature-measurement-app.elf [2 Others] 6 8
chip-lock-app.elf .flash.text 992 992
chip-lock-app.elf .flash.rodata 168 168
chip-lock-app.elf .dram0.data 8 8
chip-shell.elf .flash.text 24 24
chip-all-clusters-app.elf .flash.text 936 936
chip-all-clusters-app.elf .flash.rodata 184 184
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.debug_info,0,63016
.debug_line,0,7730
.debug_abbrev,0,4326
[Unmapped],0,2896
.debug_loc,0,1802
.debug_str,0,1670
.flash.text,972,972
.strtab,0,922
.flash.rodata,224,224
.symtab,0,176
.debug_frame,0,160
.debug_aranges,0,64
.xt.lit._ZN4chip14secure_channel21MessageCounterManagerD5Ev,0,40
.xt.lit._ZN4chip3app12WriteHandlerD5Ev,0,40
.xt.prop._ZN4chip3app12WriteHandlerD5Ev,0,40
.debug_ranges,0,24
.xt.prop._ZN4chip14secure_channel21MessageCounterManagerD2Ev,0,12
.dram0.bss,8,0
[2 Others],8,6
.xt.prop._ZN4chip6System27TLVPacketBufferBackingStoreD5Ev,0,-52
.xt.lit._ZN4chip6System27TLVPacketBufferBackingStoreD5Ev,0,-88

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.debug_info,0,153009
.debug_line,0,8178
.debug_abbrev,0,4996
[Unmapped],0,2928
.debug_loc,0,1931
.debug_str,0,1670
.flash.text,992,992
.strtab,0,922
.symtab,0,176
.flash.rodata,168,168
.debug_frame,0,160
.debug_ranges,0,88
.debug_aranges,0,64
.xt.lit._ZN4chip14secure_channel21MessageCounterManagerD5Ev,0,40
.xt.lit._ZN4chip3app12WriteHandlerD5Ev,0,40
.xt.prop._ZN4chip3app12WriteHandlerD5Ev,0,40
.xt.prop._ZN4chip14secure_channel21MessageCounterManagerD2Ev,0,12
.dram0.data,8,8
[1 Others],0,-2
.xt.prop._ZN4chip6System27TLVPacketBufferBackingStoreD5Ev,0,-52
.xt.lit._ZN4chip6System27TLVPacketBufferBackingStoreD5Ev,0,-88

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_str,0,172
.debug_info,0,111
.flash.text,24,24
.debug_loc,0,-15
[Unmapped],0,-24

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,60537
.debug_line,0,7084
[Unmapped],0,7064
.debug_abbrev,0,4273
.debug_loc,0,1806
.debug_str,0,1667
.flash.text,936,936
.strtab,0,873
.debug_frame,0,284
.flash.rodata,184,184
.symtab,0,176
.debug_aranges,0,64
.dram0.data,0,8
.riscv.attributes,0,1
.shstrtab,0,-1
.debug_ranges,0,-128

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

@andy31415 andy31415 merged commit 5eea9f2 into project-chip:master Aug 4, 2021
@pan-apple pan-apple deleted the administrator-commissioning-cluster branch August 4, 2021 02:33
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 4, 2021
@kpschoedel
Rebase and regen to fix ZAP/Android after project-chip#8680
2f2e1f4
kpschoedel added a commit to kpschoedel/connectedhomeip that referenced this pull request Aug 4, 2021
@kpschoedel
Rebase and regen to fix ZAP/Android after project-chip#8680
8c1eb5e
@bzbarsky-apple bzbarsky-apple mentioned this pull request Aug 4, 2021
Merged
mspang pushed a commit that referenced this pull request Aug 5, 2021
@kpschoedel
Add CHIP_ERROR object methods (#8784)
0fe17ec 
* Add CHIP_ERROR object methods

#### Problem

Having CHIP_ERROR be a class type provides type safety and the option to
trace the source of errors. Since all platforms now use the class type,
transitional code that provided for CHIP_ERROR to be either a class or
integer type is no longer required and can be removed, which simplifies
the class and some notation for using errors.

#### Change overview

- Remove the `CHIP_CONFIG_ERROR_CLASS` configuration option.
- Add instance methods to replace the static `ChipError` functions, which
  were present to allow transitional integer overloads. To avoid
  breaking PRs in flight, the static methods remain present for now,
  marked “DO NOT USE”; they will be removed in a final cleanup PR.

#### Testing

Existing tests should confirm no change to functionality.

* Rebase and regen to fix ZAP/Android after #8680

* Add assertions for bit fields
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@pan-apple
Implement administrator commissioning cluster (project-chip#8680)
9c622bb 
* Definition for AdministratorCommissioning cluster

* generated code and updated build files

* implement cluster logic

* address review comments

* address review comments

* update lock app build file

* fix Darwin build

* Fix Darwin test failures

* address review comments

* Address review comments
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@kpschoedel
Add CHIP_ERROR object methods (project-chip#8784)
e670ce5 
* Add CHIP_ERROR object methods

#### Problem

Having CHIP_ERROR be a class type provides type safety and the option to
trace the source of errors. Since all platforms now use the class type,
transitional code that provided for CHIP_ERROR to be either a class or
integer type is no longer required and can be removed, which simplifies
the class and some notation for using errors.

#### Change overview

- Remove the `CHIP_CONFIG_ERROR_CLASS` configuration option.
- Add instance methods to replace the static `ChipError` functions, which
  were present to allow transitional integer overloads. To avoid
  breaking PRs in flight, the static methods remain present for now,
  marked “DO NOT USE”; they will be removed in a final cleanup PR.

#### Testing

Existing tests should confirm no change to functionality.

* Rebase and regen to fix ZAP/Android after project-chip#8680

* Add assertions for bit fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@tcarmelveilleux tcarmelveilleux tcarmelveilleux approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
examples review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Commissioning Cluster and Initiate Pairing command
6 participants
@pan-apple @tcarmelveilleux @andy31415 @msandstedt @bzbarsky-apple @woody-apple