Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Telink Docker image instability #8660

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Fix Telink Docker image instability #8660

merged 2 commits into from
Jul 28, 2021

Conversation

rikorsev
Copy link
Contributor

@rikorsev rikorsev commented Jul 28, 2021 •
edited
Loading

Problem

Change overview

Instability occurs due to Zephyr repo was not versioned. Now Zephyr version is specified as v2.5.0

Testing

Tested manually. Steps:

  1. build new docker image
  2. run $ ./scripts/examples/telink_example.sh lighting-app tlsr9518adk80d in the docker container
  3. check that build was successful

@andy31415 andy31415 added hotfix urgent fix needed, can bypass review review - pending SDK Approved and removed review - approved labels Jul 28, 2021
@pullapprove pullapprove bot added review - approved and removed hotfix urgent fix needed, can bypass review review - pending labels Jul 28, 2021
@andy31415
Copy link
Contributor

Marking as hotfix: build breakage that we only worked around.

@andy31415
Copy link
Contributor

Before merging, waiting for the Dockerfile version to also be updated.

@andy31415 andy31415 merged commit 435df3e into project-chip:master Jul 28, 2021
@rikorsev rikorsev mentioned this pull request Jul 28, 2021
Merged
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@rikorsev
Fix Telink Docker image instability (project-chip#8660)
1b2f226 
* Fix Telink Docker image instability

* Update chip-build/version file to 0.4.33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@LuDuda LuDuda LuDuda approved these changes

@andy31415 andy31415 andy31415 approved these changes

@mspang mspang mspang approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@saurabhst saurabhst Awaiting requested review from saurabhst

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees
No one assigned
Labels
github integrations review - approved workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Telink build docker image does not seem stable
6 participants
@rikorsev @andy31415 @mspang @LuDuda @bzbarsky-apple @Damian-Nordic