-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nrf support for scripts/build/build_examples.py #8642
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
pullapprove
bot
requested review from
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
mspang
July 27, 2021 16:37
This comment has been minimized.
This comment has been minimized.
can this 'correct version' be checked by the build script?connectedhomeip/scripts/build/builders/nrf.py Lines 97 to 107 in 1253bee
This comment was generated by todo based on a
|
Size increase report for "gn_qpg-example-build" from 6e96fca
Full report output
|
Size increase report for "nrfconnect-example-build" from 6e96fca
Full report output
|
Size increase report for "esp32-example-build" from 6e96fca
Full report output
|
mspang
approved these changes
Jul 27, 2021
bzbarsky-apple
approved these changes
Jul 28, 2021
Damian-Nordic
approved these changes
Jul 28, 2021
LuDuda
approved these changes
Jul 28, 2021
msandstedt
approved these changes
Jul 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Add nrf builds to the example_build.py * Added a bunch of licenses * Detect dry run and skip validation of environment variables * Fix typo in runner naming for dry run detect * Add validation for nrf version in the compile script * Fix unit tests * Remove the double-generate output in the dry run of commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Need to migrate builds to a unified build script:
Change overview
Testing
Unit test updated
Manually ran
./scripts/build/build_examples.py --platform nrf build
for full test and./scripts/build/build_examples.py --app shell build
for partial test