Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EFR32 to use GSDK3.2.1 #8612

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Update EFR32 to use GSDK3.2.1 #8612

merged 1 commit into from
Jul 27, 2021

Conversation

jmartinez-silabs
Copy link
Member

@jmartinez-silabs jmartinez-silabs commented Jul 23, 2021 •
edited
Loading

Problem

No current issue but new GSDK is needed to keep up with upcomming thread needs
We also plan to support Matter on a new board.

Change overview

  • Update efr32_sdk submodule
  • Path for Freertos files changes
  • Add some files for silabs PSA_CRYPTO
  • Add some MBEDTLS configurations for PSA_CRYPTO and remove some unneccesary ones.
  • Update BLE GATT db
  • Add BLE api calls

Testing

Build lock, lighting, window cover examples on multiple boards. (BRD4161A, BRD4164A, BRD4166A)
With The python controller complete commissioning and send zcl OnOff toggle command.

@saurabhst
Copy link
Contributor

@jmartinez-silabs I see that BRD4180A is not listed among the parts which have been tested . Assuming that this part (MG21) might not be a right candidate for matter SDK support considering that it has constrained RAM and FLASH configurations. Just wanted to clarify.

@jmartinez-silabs
Copy link
Member Author

@saurabhst We would like to have Matter build on MG21 again, but currently we are struggling to fit in our 96k of RAM of that mcu family. For example the lighting example is 2.8K over the capacity. RAM Optimization efforts will be done but currently we are putting pause on MG21 and focusing no other aspect.

@saurabhst
Copy link
Contributor

@saurabhst We would like to have Matter build on MG21 again, but currently we are struggling to fit in our 96k of RAM of that mcu family. For example the lighting example is 2.8K over the capacity. RAM Optimization efforts will be done but currently we are putting pause on MG21 and focusing no other aspect.

Would you mind putting this note some where in instructions or README so that other users having these platforms are aware of ?

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< testing pull approve >>

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< testing pull approve >>

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< testing pull approve >>>

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< testing pull approve >>

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<< testing pull approve >>

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

woody-apple
woody-apple reviewed Jul 23, 2021
View reviewed changes
Copy link
Contributor

@woody-apple woody-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/pullapprove-test

version: 3

# https://developer.github.com/v3/previews/#draft-pull-requests
github_api_version: "shadow-cat-preview"

############################################################
#  Conditions
############################################################

pullapprove_conditions:
    ############################################################
    #  License Checks
    ############################################################
    - condition: "'*license/cla*' in statuses.successful"
      unmet_status: "pending"
      explanation: "CLA must be agreed to by all contributors"

    ############################################################
    #  Draft PRs
    ############################################################
    - condition: "'WIP' not in title"
      unmet_status: "pending"
      explanation: "Work in progress"

    - condition: "not draft"
      unmet_status: "pending"
      explanation: "Work in progress"

    ############################################################
    #  Conditions to Skip Review
    ############################################################
    - condition: "base.ref == 'master'"
      unmet_status: "success"
      explanation: "Review not required unless merging to master"

    ############################################################
    #  Bypass reviews
    ############################################################
    - "'hotfix' not in labels"

    ############################################################
    #  Required status checks
    ############################################################
    - condition: "'*restyle*' in statuses.successful"
      unmet_status: "failure"
      explanation: "Style must be inline before reviewing can be complete"

############################################################
#  Notifications
############################################################

notifications:
    ############################################################
    #  New contributors
    ############################################################
    - when: pull_request.opened
      if: "author_association == 'FIRST_TIME_CONTRIBUTOR'"
      comment: |
          Hey @{{ author }}, thanks for the PR! The review will start once
          the tests and CI checks have passed. If they don't, please review
          the logs and try to fix the issues (ask for help if you can't
          figure it out). A reviewer will be assigned once the tests are
          passing and they'll walk you through getting the PR finished
          and merged.

overrides:
    - if: '"SDK Approved" in labels'
      status: pending

groups:
    ############################################################
    #  Shared Reviewer Groups
    ############################################################
    shared-reviewers-amazon:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-amazon]
        reviews:
            request: 1
    shared-reviewers-apple:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-apple]
        reviews:
            request: 1
    shared-reviewers-comcast:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-comcast]
        reviews:
            request: 1
    shared-reviewers-google:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-google]
        reviews:
            request: 1
    shared-reviewers-nordic:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-nordic]
        reviews:
            request: 1
    shared-reviewers-samsung:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-samsung]
        reviews:
            request: 1
    shared-reviewers-silabs:
        type: optional
        conditions:
            - files.include('*')
        reviewers:
            teams: [reviewers-silabs]
        reviews:
            request: 1

    ############################################################
    #  Base Required Reviewers
    ############################################################
    required-reviewers:
        description: >
            [Required
            Reviewers](https://github.com/project-chip/connectedhomeip/blob/master/CONTRIBUTING.md#review-requirements)
            This is the main group of required reviews for general pull
            requests.
        type: required
        requirements:
            - len(groups.approved.include('shared-reviewers-*')) >= 3
        reviews:
            required: 0
        labels:
            approved: "review - approved"
            pending: "review - pending"
            rejected: "review - changed requested"

    ############################################################
    #  Label Based Reviewers
    ############################################################
    codeowners-android:
        type: optional
        conditions:
            - "'android' in labels"
        reviewers:
            teams:
                - codeowners-android
        reviews:
            request: 1

    codeowners-app:
        type: optional
        conditions:
            - "'app' in labels"
        reviewers:
            teams:
                - codeowners-app
        reviews:
            request: 1

    codeowners-ble:
        type: optional
        conditions:
            - "'ble' in labels"
        reviewers:
            teams:
                - codeowners-ble
        reviews:
            request: 1

    codeowners-controller:
        type: optional
        conditions:
            - "'controller' in labels"
        reviewers:
            teams:
                - codeowners-controller
        reviews:
            request: 1

    codeowners-darwin:
        type: optional
        conditions:
            - "'darwin' in labels"
        reviewers:
            teams:
                - codeowners-darwin
        reviews:
            request: 1

    codeowners-crypto:
        type: optional
        conditions:
            - "'crypto' in labels"
        reviewers:
            teams:
                - codeowners-crypto
        reviews:
            request: 1

    codeowners-inet:
        type: optional
        conditions:
            - "'inet' in labels"
        reviewers:
            teams:
                - codeowners-inet
        reviews:
            request: 2

    codeowners-core:
        type: optional
        conditions:
            - "'core' in labels"
        reviewers:
            teams:
                - codeowners-core
        reviews:
            request: 2

    codeowners-protocols:
        type: optional
        conditions:
            - "'protocols' in labels"
        reviewers:
            teams:
                - codeowners-protocols
        reviews:
            request: 1

    codeowners-shell:
        type: optional
        conditions:
            - "'shell' in labels"
        reviewers:
            teams:
                - codeowners-shell
        reviews:
            request: 1

    codeowners-support:
        type: optional
        conditions:
            - "'support' in labels"
        reviewers:
            teams:
                - codeowners-support
        reviews:
            request: 1

    codeowners-platform:
        type: optional
        conditions:
            - "'platform' in labels"
        reviewers:
            teams:
                - codeowners-platform
        reviews:
            request: 1

    codeowners-qrcode:
        type: optional
        conditions:
            - "'qrcode' in labels"
        reviewers:
            teams:
                - codeowners-qrcode
        reviews:
            request: 1

    codeowners-setup-payload:
        type: optional
        conditions:
            - "'setup payload' in labels"
        reviewers:
            teams:
                - codeowners-setup-payload
        reviews:
            request: 1

    codeowners-system:
        type: optional
        conditions:
            - "'system' in labels"
        reviewers:
            teams:
                - codeowners-system
        reviews:
            request: 1

    codeowners-test-driver:
        type: optional
        conditions:
            - "'test driver' in labels"
        reviewers:
            teams:
                - codeowners-test-driver
        reviews:
            request: 1

    codeowners-github:
        type: optional
        conditions:
            - "'github' in labels"
        reviewers:
            teams:
                - codeowners-github
        reviews:
            request: 1

    codeowners-vscode:
        type: optional
        conditions:
            - "'vscode' in labels"
        reviewers:
            teams:
                - codeowners-vscode
        reviews:
            request: 2

    codeowners-integrations:
        type: optional
        conditions:
            - "'integrations' in labels"
        reviewers:
            teams:
                - codeowners-integrations
        reviews:
            request: 1

    codeowners-transport:
        type: optional
        conditions:
            - "'transport' in labels"
        reviewers:
            teams:
                - codeowners-transport
        reviews:
            request: 1

    codeowners-scripts:
        type: optional
        conditions:
            - "'scripts' in labels"
        reviewers:
            teams:
                - codeowners-scripts
        reviews:
            request: 1

    codeowners-documentation:
        type: optional
        conditions:
            - "'documentation' in labels"
        reviewers:
            teams:
                - codeowners-documentation
        reviews:
            request: 1

    codeowners-gn:
        type: optional
        conditions:
            - "'gn' in labels"
        reviewers:
            teams:
                - codeowners-gn
        reviews:
            request: 1

@pullapprove
Copy link

pullapprove bot commented Jul 23, 2021

View the results of /pullapprove-test

@github-actions
Copy link

Size increase report for "esp32-example-build" from 762a204

File Section File VM
chip-shell.elf .flash.text -32 -32
chip-ipv6only-app.elf .flash.text 172 172
chip-temperature-measurement-app.elf .flash.text 60 60
chip-lock-app.elf .flash.text 64 64
Full report output 
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,32
.flash.text,-32,-32

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,172,172
[Unmapped],0,-172

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

@jmartinez-silabs
Copy link
Member Author

@bzbarsky-apple @Damian-Nordic @yufengwangca @chrisdecenzo Please take a look.

@jmartinez-silabs jmartinez-silabs merged commit 5d91959 into project-chip:master Jul 27, 2021
@jmartinez-silabs jmartinez-silabs deleted the gsdk_3_2 branch July 27, 2021 18:48
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@jmartinez-silabs
Update EFR32 to use GSDK3.2.1. (project-chip#8612)
6ec0bda 
restyle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woody-apple woody-apple woody-apple left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@hawk248 hawk248 Awaiting requested review from hawk248

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@msandstedt msandstedt Awaiting requested review from msandstedt

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
efr32 examples platform review - approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jmartinez-silabs @saurabhst @andy31415 @woody-apple @Damian-Nordic