Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/HSM-P256-Signature-asn1-to-raw #8534

Conversation

sujaygkulkarni-nxp
Copy link
Contributor

@sujaygkulkarni-nxp sujaygkulkarni-nxp commented Jul 21, 2021

Problem

  • HSM P256 signature is in ASN.1 DER format

Change overview

Converting HSM P256 signature from ASN.1 DER format to raw format

Testing

  • Tested using CHIPCryptoPALTest unit tests

src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Outdated Show resolved Hide resolved
src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Outdated Show resolved Hide resolved
src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, if the existing review comments get fixed.

…ub.com/sujaygkulkarni-nxp/connectedhomeip into feature/HSM-P256-Signature-asn1-to-raw

# Conflicts:
#	src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp
@github-actions
Copy link

Size increase report for "esp32-example-build" from 762a204

File Section File VM
chip-lock-app.elf .flash.text 64 64
chip-temperature-measurement-app.elf .flash.text 60 60
chip-shell.elf .flash.text -32 -32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
[Unmapped],0,32
.flash.text,-32,-32


@sujaygkulkarni-nxp
Copy link
Contributor Author

@tcarmelveilleux @andy31415 @emargolis @yufengwangca @woody-apple @bzbarsky-apple Could you please merge this PR ?

@andy31415 andy31415 merged commit 22666ec into project-chip:master Jul 27, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* converting hsm signature from asn format to raw format

* reduced buffer to 80 bytes

* restyled

* Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp

Co-authored-by: Evgeny Margolis <[email protected]>

* Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp

Co-authored-by: Evgeny Margolis <[email protected]>

* Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp

Co-authored-by: Evgeny Margolis <[email protected]>

* Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp

Co-authored-by: Evgeny Margolis <[email protected]>

* restyled

* Using new asn1 apis

* restyled

* warning fix- specifying the type explicitly

* Trigger Build

Co-authored-by: Jagadish B E <[email protected]>
Co-authored-by: Justin Wood <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Jagadish-NXP <[email protected]>
@sujaygkulkarni-nxp sujaygkulkarni-nxp deleted the feature/HSM-P256-Signature-asn1-to-raw branch January 16, 2022 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants