-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/HSM-P256-Signature-asn1-to-raw #8534
Merged
andy31415
merged 19 commits into
project-chip:master
from
sujaygkulkarni-nxp:feature/HSM-P256-Signature-asn1-to-raw
Jul 27, 2021
Merged
feature/HSM-P256-Signature-asn1-to-raw #8534
andy31415
merged 19 commits into
project-chip:master
from
sujaygkulkarni-nxp:feature/HSM-P256-Signature-asn1-to-raw
Jul 27, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
bhaskar-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
yufengwangca
July 21, 2021 05:58
emargolis
reviewed
Jul 21, 2021
emargolis
approved these changes
Jul 21, 2021
bzbarsky-apple
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, if the existing review comments get fixed.
Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
Co-authored-by: Evgeny Margolis <[email protected]>
woody-apple
approved these changes
Jul 22, 2021
…tedhomeip into feature/HSM-P256-Signature-asn1-to-raw
…ub.com/sujaygkulkarni-nxp/connectedhomeip into feature/HSM-P256-Signature-asn1-to-raw
…ub.com/sujaygkulkarni-nxp/connectedhomeip into feature/HSM-P256-Signature-asn1-to-raw # Conflicts: # src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp
tcarmelveilleux
approved these changes
Jul 23, 2021
yufengwangca
approved these changes
Jul 23, 2021
…ujaygkulkarni-nxp/connectedhomeip into feature/HSM-P256-Signature-asn1-to-raw
Size increase report for "esp32-example-build" from 762a204
Full report output
|
andy31415
approved these changes
Jul 26, 2021
@tcarmelveilleux @andy31415 @emargolis @yufengwangca @woody-apple @bzbarsky-apple Could you please merge this PR ? |
saurabhst
approved these changes
Jul 27, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* converting hsm signature from asn format to raw format * reduced buffer to 80 bytes * restyled * Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Co-authored-by: Evgeny Margolis <[email protected]> * Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Co-authored-by: Evgeny Margolis <[email protected]> * Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Co-authored-by: Evgeny Margolis <[email protected]> * Update src/crypto/hsm/nxp/CHIPCryptoPALHsm_SE05X_P256.cpp Co-authored-by: Evgeny Margolis <[email protected]> * restyled * Using new asn1 apis * restyled * warning fix- specifying the type explicitly * Trigger Build Co-authored-by: Jagadish B E <[email protected]> Co-authored-by: Justin Wood <[email protected]> Co-authored-by: Evgeny Margolis <[email protected]> Co-authored-by: Jagadish-NXP <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
Converting HSM P256 signature from ASN.1 DER format to raw format
Testing