Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermostat User Interface Configuration Cluster #8511

Merged
merged 4 commits into from Aug 4, 2021
Merged

Thermostat User Interface Configuration Cluster #8511

merged 4 commits into from Aug 4, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jul 20, 2021

Problem

Current SDK lacks of support of the thermostat user interface configuration cluster. This PR adds support for that.

Change overview

Add thermostat user interface configuration cluster

Testing

Tested on a nordic based accessory.

Copy link
Contributor

@chrisbeach59 chrisbeach59 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZAP file and gen changes only

@andy31415
Copy link
Contributor

@eve-cxrp - merge conflicts

@ghost
Copy link
Author

ghost commented Aug 4, 2021

@andy31415 resolved.

I don't know what: Needs /gcbrun from a collaborator means...

@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Size increase report for "esp32-example-build" from 5eea9f2

File Section File VM
chip-all-clusters-app.elf .flash.rodata 80 80
chip-all-clusters-app.elf .flash.text 12 12
chip-all-clusters-app.elf .dram0.bss 0 8
chip-all-clusters-app.elf .dram0.heap_start 0 -8
chip-ipv6only-app.elf .flash.text 172 172
chip-temperature-measurement-app.elf .flash.text 60 60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_str,0,131
.debug_info,0,80
.flash.rodata,80,80
.strtab,0,68
.debug_loc,0,56
.debug_line,0,32
.debug_frame,0,16
.symtab,0,16
.flash.text,12,12
.dram0.bss,8,0
.riscv.attributes,0,-3
.dram0.heap_start,-8,0
[ELF Headers],0,-40
[Unmapped],0,-92

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize
.flash.text,172,172
[Unmapped],0,-172

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,60,60
[Unmapped],0,-60


@andy31415 andy31415 merged commit 4f3fa5f into project-chip:master Aug 4, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* add thermostat user interface configuration claster to controller-clusters.zap

* add thermostat user interface configuration cluster to zap_cluster_list.py

* add thermostat user interface configuration cluster to all-clusters-app

* regen all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants