Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable scripts/build test #8490

Merged

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 19, 2021

Problem

This test is failing as of 392d085 ("ESP32: Optimize the time taken by esp32
workflows (#8409)").

Change overview

There is no documentation about how to update the expectations. Disable
this test for now.

Testing

Ran gn_build.sh

@mspang mspang added the hotfix urgent fix needed, can bypass review label Jul 19, 2021
This test is failing as of 392d085 ("ESP32: Optimize the time taken by esp32
workflows (project-chip#8409)").

There is no documentation about how to update the expectations. Disable
this test for now.
@mspang mspang force-pushed the for-chip/disable-build-test branch from 59539ff to 7742360 Compare July 19, 2021 23:23
Copy link
Contributor

@tcarmelveilleux tcarmelveilleux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I am blocked.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 369c743

File Section File VM
chip-lock-app.elf .flash.text -64 -64
chip-temperature-measurement-app.elf .flash.text 60 60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-ipv6only-app.elf and ./pull_artifact/chip-ipv6only-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
[Unmapped],0,4036
.flash.text,60,60

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize


@bzbarsky-apple bzbarsky-apple merged commit d24b3c0 into project-chip:master Jul 20, 2021
@bzbarsky-apple
Copy link
Contributor

@sweetymhaiske @dhrishi Do you know about this test?

@sweetymhaiske
Copy link
Contributor

@sweetymhaiske @dhrishi Do you know about this test?

The problem aroused because this script scripts/build/expected_all_platform_commands.txt was added 3 days back, and it uses sdkconfig_devkit.defaults , however in #8409 which was raised 4 days back (it was not rebased), all occurrences of sdkconfig_devkit.defaults were replaced with sdkconfig.defaults.

The PR for fixes #8499

@mspang mspang deleted the for-chip/disable-build-test branch July 20, 2021 16:53
drempelg pushed a commit to drempelg/connectedhomeip that referenced this pull request Jul 20, 2021
This test is failing as of 392d085 ("ESP32: Optimize the time taken by esp32
workflows (project-chip#8409)").

There is no documentation about how to update the expectations. Disable
this test for now.
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
This test is failing as of 392d085 ("ESP32: Optimize the time taken by esp32
workflows (project-chip#8409)").

There is no documentation about how to update the expectations. Disable
this test for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix urgent fix needed, can bypass review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants