-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine the no-detail-logging and no-progress-logging builds with the gcc_debug build #8463
Merged
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:combine-no-logging-builds
Jul 20, 2021
Merged
Combine the no-detail-logging and no-progress-logging builds with the gcc_debug build #8463
Damian-Nordic
merged 1 commit into
project-chip:master
from
bzbarsky-apple:combine-no-logging-builds
Jul 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
saurabhst and
woody-apple
July 16, 2021 21:46
mspang
approved these changes
Jul 16, 2021
andy31415
approved these changes
Jul 16, 2021
Should we just combine all of them? |
It's a bit more work for the others because we have to do the CodeQL bits, but we could do this, yes.... |
jmartinez-silabs
approved these changes
Jul 19, 2021
bzbarsky-apple
force-pushed
the
combine-no-logging-builds
branch
from
July 20, 2021 03:01
e1ee438
to
09dd5d7
Compare
@woody-apple @Damian-Nordic @msandstedt @saurabhst @LuDuda Take a look please? Should help a bit with our CI latency. |
saurabhst
approved these changes
Jul 20, 2021
… gcc_debug build. This better amortizes setup costs: the builds themselves are pretty cheap compared to the various setup we have to do to get to them.
bzbarsky-apple
force-pushed
the
combine-no-logging-builds
branch
from
July 20, 2021 03:39
09dd5d7
to
5458ac6
Compare
Size increase report for "esp32-example-build" from d24b3c0
Full report output
|
Damian-Nordic
approved these changes
Jul 20, 2021
drempelg
pushed a commit
to drempelg/connectedhomeip
that referenced
this pull request
Jul 20, 2021
… gcc_debug build. (project-chip#8463) This better amortizes setup costs: the builds themselves are pretty cheap compared to the various setup we have to do to get to them.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
… gcc_debug build. (project-chip#8463) This better amortizes setup costs: the builds themselves are pretty cheap compared to the various setup we have to do to get to them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better amortizes setup costs: the builds themselves are pretty
cheap compared to the various setup we have to do to get to them.
Problem
We use a lot of CI resources for these logging-compilation tests. Something like 7-8 minutes of CI time of which only about 2-2.5 minutes is the actual build.
Change overview
Just do these builds as part of the gcc_debug job. Don't run tests for them, because we're just trying to ensure things compile.
Testing