Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove clang_experimental build for real this time #8462

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

mspang
Copy link
Contributor

@mspang mspang commented Jul 16, 2021

Problem

This build was intended to be removed in 9488c1a ("Remove linux
clang_experimental build (#7467)") but was left in the matrix and has
since been wasting capacity.

Change overview

To prevent waste going forward, make unrecognized build types in the
matrix fail when deriving the arguments. Also, simplify the arguments
setting a bit - for brevity options that are defaults are not specified;
the original builds worked this way but the new logging build did not.

Testing

Run CI.

This build was intended to be removed in 9488c1a ("Remove linux
clang_experimental build (project-chip#7467)") but was left in the matrix and has
since been wasting capacity.

To prevent waste going forward, make unrecognized build types in the
matrix fail when deriving the arguments. Also, simplify the arguments
setting a bit - for brevity options that are defaults are not specified;
the original builds worked this way but the new logging build did not.
@github-actions
Copy link

Size increase report for "esp32-example-build" from f4a6b28

File Section File VM
chip-all-clusters-app.elf .flash.text -16 -16
chip-temperature-measurement-app.elf .flash.text -51 -60
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.xt.prop._ZN4chip6System5Mutex6UnlockEv,0,108
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,48
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,48
[Unmapped],0,16
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE14_LockChipStackEv,0,12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,12
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE16_UnlockChipStackEv,0,12
.flash.text,-16,-16
.xt.prop._ZN4chip11DeviceLayer8Internal26GenericPlatformManagerImplINS0_19PlatformManagerImplEE14_InitChipStackEv,0,-40
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE10_PostEventEPKNS0_15ChipDeviceEventE,0,-80
.xt.lit._ZN4chip6System5Mutex6UnlockEv,0,-128

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,-60,-51
[Unmapped],0,-4045


@mspang
Copy link
Contributor Author

mspang commented Jul 19, 2021

@mspang mspang merged commit ff2a1e5 into project-chip:master Jul 19, 2021
@mspang mspang deleted the for-chip/rm-clang-exp2 branch July 19, 2021 19:58
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
This build was intended to be removed in 9488c1a ("Remove linux
clang_experimental build (project-chip#7467)") but was left in the matrix and has
since been wasting capacity.

To prevent waste going forward, make unrecognized build types in the
matrix fail when deriving the arguments. Also, simplify the arguments
setting a bit - for brevity options that are defaults are not specified;
the original builds worked this way but the new logging build did not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants