-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove clang_experimental build for real this time #8462
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build was intended to be removed in 9488c1a ("Remove linux clang_experimental build (project-chip#7467)") but was left in the matrix and has since been wasting capacity. To prevent waste going forward, make unrecognized build types in the matrix fail when deriving the arguments. Also, simplify the arguments setting a bit - for brevity options that are defaults are not specified; the original builds worked this way but the new logging build did not.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
July 16, 2021 21:43
andy31415
approved these changes
Jul 16, 2021
bzbarsky-apple
approved these changes
Jul 16, 2021
Size increase report for "esp32-example-build" from f4a6b28
Full report output
|
saurabhst
approved these changes
Jul 19, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
This build was intended to be removed in 9488c1a ("Remove linux clang_experimental build (project-chip#7467)") but was left in the matrix and has since been wasting capacity. To prevent waste going forward, make unrecognized build types in the matrix fail when deriving the arguments. Also, simplify the arguments setting a bit - for brevity options that are defaults are not specified; the original builds worked this way but the new logging build did not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This build was intended to be removed in 9488c1a ("Remove linux
clang_experimental build (#7467)") but was left in the matrix and has
since been wasting capacity.
Change overview
To prevent waste going forward, make unrecognized build types in the
matrix fail when deriving the arguments. Also, simplify the arguments
setting a bit - for brevity options that are defaults are not specified;
the original builds worked this way but the new logging build did not.
Testing
Run CI.