Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off CodeQL for pushes to non-ToT branches #8448

Merged
merged 1 commit into from
Jul 16, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

We end up running CodeQL for things like test event cherry-picks

Change overview

Only run it for pushes to master.

Testing

Tried pushing to my fork of the connectedhomeip, both to master and a non-master branch. The push to master ran CodeQL; the non-master branch did not.

@github-actions
Copy link

Size increase report for "esp32-example-build" from 6d61387

File Section File VM
chip-shell.elf .flash.text 32 32
chip-lock-app.elf .flash.text 64 64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.flash.text,32,32
[Unmapped],0,-32

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
.flash.text,64,64
[Unmapped],0,-64


@andy31415 andy31415 merged commit 8a4f239 into project-chip:master Jul 16, 2021
@bzbarsky-apple bzbarsky-apple deleted the codeql-only-master branch July 16, 2021 17:31
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants