-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix leftover from #8236 and make BufferReader/Writer support Span #8408
Merged
bzbarsky-apple
merged 14 commits into
project-chip:master
from
tcarmelveilleux:fixes/nits-from-8236
Jul 20, 2021
Merged
Fix leftover from #8236 and make BufferReader/Writer support Span #8408
bzbarsky-apple
merged 14 commits into
project-chip:master
from
tcarmelveilleux:fixes/nits-from-8236
Jul 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ort Span - Fix leftover nits from @bzbarsky-apple's review of project-chip#8236 - In order to add span support cleanly, added Span support to Reader and BufferWriter, and fixed all necessary breakage. Testing done: pass all unit tests and CASE cert tests
De-uint16-ify everything related to this libraryconnectedhomeip/src/transport/raw/MessageHeader.cpp Lines 147 to 150 in 672ddc0
This comment was generated by todo based on a
|
pullapprove
bot
requested review from
andy31415,
bhaskar-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
vivien-apple
July 15, 2021 02:46
Size increase report for "esp32-example-build" from 193eb3c
Full report output
|
Size increase report for "nrfconnect-example-build" from 193eb3c
Full report output
|
holbrookt
approved these changes
Jul 15, 2021
bzbarsky-apple
approved these changes
Jul 15, 2021
- Assign to output spans - Use new span function for validity checks (`is_span_usable`) - Replace an untested CHIPCert.cpp usage with tested version
msandstedt
approved these changes
Jul 16, 2021
bzbarsky-apple
approved these changes
Jul 16, 2021
mspang
approved these changes
Jul 19, 2021
jelderton
approved these changes
Jul 20, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…ort Span (project-chip#8408) * Fix leftover from project-chip#8236 and make BufferReader/Writer support Span - Fix leftover nits from @bzbarsky-apple's review of project-chip#8236 - In order to add span support cleanly, added Span support to Reader and BufferWriter, and fixed all necessary breakage. Testing done: pass all unit tests and CASE cert tests * Fix mbedTLS usage of EcdsaAsn1SignatureToRaw * Apply review comments from @bzbarsky-apple * Use some span reassign instead of out_size ref * Restyled by clang-format * Remove unnecessary nullptr checks handled by Span::size() * Improve IntegerToDer test coverage - Assign to output spans - Use new span function for validity checks (`is_span_usable`) - Replace an untested CHIPCert.cpp usage with tested version * Add is_span_usable() tests * Restyled by clang-format * Grammar fix to kick CI * Commit forgotten removal of obsolete ConvertIntegerRawToDER from CHIPCert.h * Apply review comments from @mspang * Fix clang Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Span
rather than<uint8_t *, size_t>
sets of args. To do so, it was cleaner to add Span support toReader
andBufferWriter
, so I did so.Change overview
Span
support toReader
andBufferWriter
, and fixed all necessary breakage.is_span_usable
)RawIntegerToDer
Testing
ninja -C out/host check
on LinuxReader
andBufferWriter
features andRawIntegerToDer