Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TV app] Enable Tests #8327

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

lazarkov
Copy link
Contributor

Problem

TV example app has tests which are not enabled on CI

Change overview

  • Updated tests.yaml to include TV app tests

Testing

  • Run the ./scripts/tests/test_suites.sh -a tv

@lazarkov lazarkov force-pushed the feature/enable-tv-app-testing branch from 09267d0 to c37146d Compare July 13, 2021 16:26
Copy link
Contributor

@bzbarsky-apple bzbarsky-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only running the tv tests on Linux. Should we run them on Darwin too, or do we figure the value of that is fairly low?

@lazarkov
Copy link
Contributor Author

This is only running the tv tests on Linux. Should we run them on Darwin too, or do we figure the value of that is fairly low?

I haven't saw it as necessary. I can enable it in next PR if needed?

@andy31415 andy31415 merged commit 67d91c2 into project-chip:master Jul 14, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* Enable TV app testing

* Update tests per latest comments
@lazarkov lazarkov deleted the feature/enable-tv-app-testing branch December 23, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants