Fix IM interval typo and tests #8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
yunhanw-google
requested review from
msandstedt
and removed request for
msandstedt,
hawk248,
chrisdecenzo,
Damian-Nordic and
jepenven-silabs
pullapprove
bot
requested review from
chrisdecenzo,
Damian-Nordic,
hawk248 and
jepenven-silabs
bzbarsky-apple
approved these changes
Jul 13, 2021
saurabhst
approved these changes
Jul 13, 2021
andy31415
reviewed
Jul 13, 2021
yunhanw-google
force-pushed
the
bug/fix_typo_in_subscribe
branch
from
895657d to
802c4e6
Compare
yunhanw-google
force-pushed
the
bug/fix_typo_in_subscribe
branch
from
802c4e6 to
12234bc
Compare
andy31415
approved these changes
Jul 16, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
For IM subscribe min/max interval, it uses wrong tag inside
Change overview
Update the right tag for min/max internal in IM subscribe min/max interval
Testing
Previously the test use same value, 1 for event number, update test with different value so that it would catch this error.