Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary rebuild steps of docker build #8282

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

bukepo
Copy link
Contributor

@bukepo bukepo commented Jul 10, 2021

Problem

  • Avoid unnecessary rebuild steps of docker build when chip binary is updated.

Change overview

Move chip-0.0-cp37-abi3-linux_x86_64.whl after apt-get installs.

Testing

I utilize this change to accelerate finding root cause of #7460.

@bukepo bukepo changed the title Increase reusable steps of docker build Avoid unnecessary rebuild steps of docker build Jul 10, 2021
@bzbarsky-apple
Copy link
Contributor

/rebase

@woody-apple woody-apple force-pushed the ci/reuse-docker-steps branch from 30cea52 to a00816c Compare July 13, 2021 04:16
@github-actions
Copy link

Size increase report for "esp32-example-build" from 1486eb7

File Section File VM
chip-all-clusters-app.elf .flash.text 44 44
chip-temperature-measurement-app.elf .flash.text 56 56
chip-lock-app.elf .flash.text -64 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-pigweed-app.elf and ./pull_artifact/chip-pigweed-app.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.flash.text,44,44
.xt.prop._ZN4chip11DeviceLayer8Internal26GenericPlatformManagerImplINS0_19PlatformManagerImplEE14_InitChipStackEv,0,40
.debug_loc,0,-4
.xt.prop._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,-12
[Unmapped],0,-44
.xt.lit._ZN4chip11DeviceLayer8Internal35GenericPlatformManagerImpl_FreeRTOSINS0_19PlatformManagerImplEE15_StartChipTimerEj,0,-48

Comparing ./master_artifact/chip-temperature-measurement-app.elf and ./pull_artifact/chip-temperature-measurement-app.elf:

sections,vmsize,filesize
.flash.text,56,56
[Unmapped],0,-56

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-persistent-storage.elf and ./pull_artifact/chip-persistent-storage.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-lock-app.elf and ./pull_artifact/chip-lock-app.elf:

sections,vmsize,filesize
[Unmapped],0,64
.flash.text,-64,-64


@andy31415 andy31415 merged commit e70c803 into project-chip:master Jul 13, 2021
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants