Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Make ECDSA sign/verify format spec-compliant #8261

Closed
wants to merge 9 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jul 9, 2021

A duplicate of #8236 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

tcarmelveilleux and others added 9 commits July 8, 2021 22:57
- Use raw <r,s> concatenated point format for input/output
  to ECDSA signature primitives, so that format on the wire
  matches spec. This will allow CASE to follow spec encoding.
- Update some utilities to add missign bits/pieces.
- Add associated unit tests

Fixes #8209
- Method is cheaper and more direct than conversions.
- Overall code is smaller.
- Refactor the message versions to defer to the sign_hash/verify_hash
@restyled-io restyled-io bot added the restyled label Jul 9, 2021
@restyled-io restyled-io bot closed this Jul 9, 2021
@restyled-io restyled-io bot deleted the restyled/pull-8236 branch July 9, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants