Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zap use chip::ErrorStr into the BasicFilter template of CHIPClientCallbacks.h #8213

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Zap use chip::ErrorStr into the BasicFilter template of CHIPClientCallbacks.h #8213

merged 2 commits into from
Jul 8, 2021

Conversation

vivien-apple
Copy link
Contributor

Problem

Onto some platforms CHIPClientCallbacks.h will not compile.

Change overview

  • Use %s with chip::ErrorStr(err) instead of %d with err.

Testing

  • That is just a compilation error that should be fixed with the update.

@vivien-apple vivien-apple self-assigned this Jul 8, 2021
@vivien-apple vivien-apple changed the title Zap use error str into basic filter Zap use chip::ErrorStr into basic filter Jul 8, 2021
@vivien-apple vivien-apple changed the title Zap use chip::ErrorStr into basic filter Zap use chip::ErrorStr into the BasicFilter template of CHIPClientCallbacks.h Jul 8, 2021
@franck-apple franck-apple added this to the Test Event 4 milestone Jul 8, 2021
@andy31415
Copy link
Contributor

@jmartinez-silabs @LuDuda @sagar-apple @selissia ?

@bzbarsky-apple bzbarsky-apple merged commit 046f46a into project-chip:master Jul 8, 2021
andy31415 pushed a commit that referenced this pull request Jul 9, 2021
@vivien-apple @andreilitvin
Zap use chip::ErrorStr into the BasicFilter template of CHIPClientCal…
2d07395 
…lbacks.h (#8213)

* Use %s for logging the error instead of %d into CHIPClientCallbacks.zapt

* Update gen/ folders
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
@vivien-apple
Zap use chip::ErrorStr into the BasicFilter template of CHIPClientCal…
3394114 
…lbacks.h (project-chip#8213)

* Use %s for logging the error instead of %d into CHIPClientCallbacks.zapt

* Update gen/ folders
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmartinez-silabs jmartinez-silabs jmartinez-silabs approved these changes

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@saurabhst saurabhst saurabhst approved these changes

@andy31415 andy31415 andy31415 approved these changes

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@jelderton jelderton Awaiting requested review from jelderton

@LuDuda LuDuda Awaiting requested review from LuDuda

@mspang mspang Awaiting requested review from mspang

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@selissia selissia Awaiting requested review from selissia

@woody-apple woody-apple Awaiting requested review from woody-apple

Assignees

@vivien-apple vivien-apple

Labels
app controller examples review - approved
Projects
None yet
Milestone
Test Event 4
Development

Successfully merging this pull request may close these issues.
6 participants
@vivien-apple @andy31415 @saurabhst @bzbarsky-apple @jmartinez-silabs @franck-apple