[Android] Expose discovery capabilities in SetupPayload #8178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bhaskar-apple,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
jlportillo and
msandstedt
Damian-Nordic
approved these changes
Jul 8, 2021
.../app/src/main/java/com/google/chip/chiptool/setuppayloadscanner/CHIPDeviceDetailsFragment.kt
Show resolved
Hide resolved
jlportillo
approved these changes
Jul 8, 2021
austinh0
force-pushed
the
discovery-capabilities
branch
from
22cc183 to
1314929
Compare
bzbarsky-apple
approved these changes
Jul 9, 2021
msandstedt
approved these changes
Jul 9, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
SetupPayload.javahas arendezvousInformationfield, but it is unset.Change overview
DiscoveryCapabilityenumSetupPayloadwith a set of discovery capabilities, replacingrendezvousInformationTesting