Fix python compile. #8135
Merged
Fix python compile. #8135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like ChipLogDetail is off for the controller so it throws an unused variable exception. Just moving the var into the log.
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
andy31415
approved these changes
Jul 6, 2021
andy31415
pushed a commit
that referenced
this pull request
Jul 6, 2021
Looks like ChipLogDetail is off for the controller so it throws an unused variable exception. Just moving the var into the log.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Looks like ChipLogDetail is off for the controller so it throws an unused variable exception. Just moving the var into the log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Looks like ChipLogDetail is off for the controller so it throws
an unused variable exception.
Change overview
Just moving the var into the log.
Testing
compiled chip-device-ctrl.