Move APP/gen/callback.h to src/app/common/gen/ #8065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
kedars,
LuDuda,
mspang,
saurabhst and
woody-apple
vivien-apple
changed the title
bzbarsky-apple
approved these changes
Jul 1, 2021
|
The |
jmartinez-silabs
approved these changes
Jul 2, 2021
vivien-apple
force-pushed
the
ZAP_MoveCallbackHFile
branch
from
ddfd952 to
f3e1129
Compare
woody-apple
approved these changes
Jul 2, 2021
mspang
approved these changes
Jul 2, 2021
msandstedt
approved these changes
Jul 3, 2021
vivien-apple
force-pushed
the
ZAP_MoveCallbackHFile
branch
from
f3e1129 to
897991c
Compare
|
@vivien-apple - merge conflicts |
vivien-apple
force-pushed
the
ZAP_MoveCallbackHFile
branch
from
897991c to
55f4628
Compare
vivien-apple
added a commit
to vivien-apple/connectedhomeip-1
that referenced
this pull request
Jul 7, 2021
* Move examples gen/callback.h to src/app/common/gen/callback.h * Update gen/ folders
andy31415
pushed a commit
that referenced
this pull request
Jul 8, 2021
andy31415
pushed a commit
that referenced
this pull request
Jul 8, 2021
* Move examples gen/callback.h to src/app/common/gen/callback.h * Update gen/ folders
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* Move examples gen/callback.h to src/app/common/gen/callback.h * Update gen/ folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR moves
APP/gen/callback.htosrc/app/common/gen/callback.hand instead of generating declarations for enabled clusters, it generates declarations for all clusters.Change overview
APP/gen/callback.htosrc/app/common/gen/callback.hsrc/app/common/gen/callback.hsince common does not in advance which clusters are enabled and this follow what is done foraf-structs.h,enums.hand friends.{{asUpperCamelCase}}and{{asLowerCase}}instead of{{asCamelCased}}to avoid issues with cluster names that contains characters not filtered by{{asCamelCased}}Testing
There is no feature change, not real code change. This is mostly code beeing shuffled around.