-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle Mdns: separate query responders for advertisers #8002
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current setup uses a single query responder for commissionable and operational and all the records are cleared together and added in a large group. This makes it challenging to run commissionable and operational at the same time since they can't be cleared individually and because there are duplicate records between operational and commissionable. This commit changes the code to use one query responder per advertisement type and gets the ResponseSender to loop through the query responders to filter for answers.
Co-authored-by: chrisdecenzo <[email protected]>
When multi-admin is enabled, commissionable does not need to be cleared here.connectedhomeip/src/lib/mdns/Advertiser_ImplMinimalMdns.cpp Lines 214 to 224 in b2f3800
This comment was generated by todo based on a
|
When multi-admin is enabled, operational does not need to be cleared here.connectedhomeip/src/lib/mdns/Advertiser_ImplMinimalMdns.cpp Lines 280 to 290 in b2f3800
This comment was generated by todo based on a
|
restyled-io
bot
force-pushed
the
restyled/pull-7615
branch
2 times, most recently
from
June 29, 2021 18:06
9aefcc2
to
12f7427
Compare
restyled-io
bot
force-pushed
the
restyled/pull-7615
branch
from
June 29, 2021 18:13
12f7427
to
6784c57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A duplicate of #7615 with additional commits that automatically address
incorrect style, created by Restyled.
Please review accordingly.
Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.
The following Restylers made fixes:
To incorporate these changes, you can either:
Merge this Pull Request instead of the original, or
Ask your contributor to locally incorporate these commits and push them to
the original Pull Request
Expand for example instructions
NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.
Sorry if this was unexpected. To disable it, see our documentation.