Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Mdns: separate query responders for advertisers #8002

Closed
wants to merge 6 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jun 29, 2021

A duplicate of #7615 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

cecille and others added 4 commits June 17, 2021 01:59
The current setup uses a single query responder for commissionable
and operational and all the records are cleared together and added
in a large group. This makes it challenging to run commissionable
and operational at the same time since they can't be cleared
individually and because there are duplicate records between
operational and commissionable. This commit changes the code to
use one query responder per advertisement type and gets the
ResponseSender to loop through the query responders to filter
for answers.
@todo
Copy link

todo bot commented Jun 29, 2021

When multi-admin is enabled, commissionable does not need to be cleared here.

// TODO: When multi-admin is enabled, commissionable does not need to be cleared here.
mQueryResponderAllocatorOperational.Clear();
char nameBuffer[64] = "";
/// need to set server name
ReturnErrorOnFailure(MakeInstanceName(nameBuffer, sizeof(nameBuffer), params.GetPeerId()));
FullQName operationalServiceName = mQueryResponderAllocatorOperational.AllocateQName("_chip", "_tcp", "local");
FullQName operationalServerName = mQueryResponderAllocatorOperational.AllocateQName(nameBuffer, "_chip", "_tcp", "local");
ReturnErrorOnFailure(MakeHostName(nameBuffer, sizeof(nameBuffer), params.GetMac()));


This comment was generated by todo based on a TODO comment in b2f3800 in #8002. cc @project-chip.

@restyled-io restyled-io bot added the restyled label Jun 29, 2021
@boring-cyborg boring-cyborg bot added the lib label Jun 29, 2021
@todo
Copy link

todo bot commented Jun 29, 2021

When multi-admin is enabled, operational does not need to be cleared here.

// TODO: When multi-admin is enabled, operational does not need to be cleared here.
if (params.GetCommissionAdvertiseMode() == CommssionAdvertiseMode::kCommissionableNode)
{
mQueryResponderAllocatorCommissionable.Clear();
}
else
{
mQueryResponderAllocatorCommissioner.Clear();
}
// TODO: need to detect colisions here


This comment was generated by todo based on a TODO comment in b2f3800 in #8002. cc @project-chip.

@restyled-io restyled-io bot force-pushed the restyled/pull-7615 branch 2 times, most recently from 9aefcc2 to 12f7427 Compare June 29, 2021 18:06
@restyled-io restyled-io bot force-pushed the restyled/pull-7615 branch from 12f7427 to 6784c57 Compare June 29, 2021 18:13
@restyled-io restyled-io bot closed this Jun 29, 2021
@restyled-io restyled-io bot deleted the restyled/pull-7615 branch June 29, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants