Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shell] Fix crash on startup for chip-shell #7986

Merged
merged 1 commit into from
Jun 30, 2021
Merged

[shell] Fix crash on startup for chip-shell #7986

merged 1 commit into from
Jun 30, 2021

Conversation

yufengwangca
Copy link
Contributor

@yufengwangca yufengwangca commented Jun 29, 2021

Problem

What is being fixed? Examples:
yufengw@yufengw-SEi:~/Workspace/connectedhomeip/out/debug$ ./chip-shell
[1624926656.614016][17601] CHIP:DL: CHIP task running
[1624926656.614114][17594] CHIP:SH: Max number of modules reached, _commandSetCount:10

chip-shell: ../../src/lib/shell/Engine.cpp:66: void chip::Shell::Engine::RegisterCommands(chip::Shell::shell_command_t*, unsigned int): Assertion `0' failed.
Aborted (core dumped)

We have reached the Max number of modules allowed to register in shell.

Change overview

Increase max number of modules to register from 10 to 32 to accommodate more sub-modules.

Testing

How was this tested? (at least one bullet point required)
Run ./chip-shell and confirm program does not crash.

@boring-cyborg boring-cyborg bot added the lib label Jun 29, 2021
@yufengwangca yufengwangca requested a review from mspang June 29, 2021 00:41
@yufengwangca yufengwangca changed the title [shell] Fix crash on chip-shell startup [shell] Fix crash on startup for chip-shell Jun 29, 2021
@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 10a7ac6

File Section File VM
chip-shell.elf bss 0 704
chip-shell.elf text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
bss,704,0
.debug_abbrev,0,380
.debug_info,0,44
text,16,16


@woody-apple woody-apple merged commit 5c91ac0 into project-chip:master Jun 30, 2021
@yufengwangca yufengwangca deleted the pr/shell/assert branch June 30, 2021 16:01
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants