Reset all device objects on controller shutdown #7894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs and
msandstedt
mspang
approved these changes
Jun 24, 2021
bzbarsky-apple
approved these changes
Jun 25, 2021
saurabhst
approved these changes
Jun 25, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #7892
Change overview
The device objects were getting destructed as part of DeviceController destructor. If the CASE Session was in progress, the device object tries to clear the state. That required it to access some of the system layer objects that were already freed as part of controller shutdown (that happened before the destructor was called).
This change clears the device objects as part of the controller shutdown. It clears all the state that may require access to system level objects, so that the device destructor doesn't need to access that state.
Testing
Tested using patch mentioned in #7892.
Reproduced the crash, fixed the problem and tested that the crash is gone.