Align the flag check between InetLayer::Init and InetLayer::Shutdown #7883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang,
pan-apple,
saurabhst and
woody-apple
woody-apple
approved these changes
Jun 24, 2021
mspang
approved these changes
Jun 24, 2021
saurabhst
approved these changes
Jun 28, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
The #if checking within InetLayer::Init is not aligned with InetLayer::Shutdown, this prevent me from adding new initialization code at proper place.
Change overview
Align the flag check between InetLayer::Init and InetLayer::Shutdown to guarantee mAsyncDNSResolver is initialized and shutdown symmetrically.
Testing
How was this tested? (at least one bullet point required)
No logic change, the current CI should be good enough to verify the correctness.