Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QPG6100] Fix sync of cluster attributes on manual change of light status #7878

Merged
merged 2 commits into from
Jun 24, 2021

Conversation

tima-q
Copy link
Contributor

@tima-q tima-q commented Jun 24, 2021

Problem

Manual manipulation of the light's on/off or level state should be reflected in the respective cluster attributes.
A local sync back of the state towards the attributes on the button action was missing.

Change overview

  • Calling sync of light OnOff/Level cluster status depending on the button actions.
  • Cleanup logging LightingManager/Attribute updates

Testing

  • Setup: chip-device-ctrl (TE3 image)+ qpg6100 lighting-app
  • Scenario:
    • OnOff read-out - zclread OnOff OnOff 1 1 0
    • Light OnOff status manipulated by button press
    • OnOff read-out - check if correctly changed
    • CurrentLevel read-out - zclread LevelControl CurrentLevel 1 1 0
    • Light level manipulated by button
    • CurrentLevel read-out - check if correctly changed

* Cleanup logging LightingManager/Attribute updates
@github-actions
Copy link

Size increase report for "gn_qpg6100-example-build" from ed677f0

File Section File VM
chip-qpg6100-lighting-example.out .text -40 -40
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,200
[Unmapped],0,40
.debug_info,0,21
.debug_line,0,17
.debug_str,0,-2
.text,-40,-40


@mspang mspang merged commit 0174e4a into project-chip:master Jun 24, 2021
@tima-q tima-q deleted the qpg6100/attrib_sync branch September 6, 2021 07:20
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
…atus (project-chip#7878)

* * Fix sync of cluster state on manual change of light status
* Cleanup logging LightingManager/Attribute updates

* Kick GH actions - ESP32/QEMU test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants