-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WindowCovering: Update cluster definition xml #7876
Merged
mspang
merged 4 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-part-11
Jun 25, 2021
Merged
WindowCovering: Update cluster definition xml #7876
mspang
merged 4 commits into
project-chip:master
from
jmeg-sfy:jmeg-sfy/window-covering-part-11
Jun 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
sagar-apple
June 24, 2021 12:00
msandstedt
approved these changes
Jun 24, 2021
saurabhst
approved these changes
Jun 24, 2021
woody-apple
approved these changes
Jun 24, 2021
mspang
approved these changes
Jun 24, 2021
Size increase report for "gn_qpg6100-example-build" from 2f0c691
Full report output
|
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
* WC: Update WindowCovering with updated xml * WC: Update scene for compilation + Add missing callback * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]> Co-authored-by: Michael Spang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
This is the first part of a multiple series of PRs to update the examples for Window Covering in order to simplify code reviews
Testing
How was this tested? (at least one bullet point required)