Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WindowCovering: Update cluster definition xml #7876

Merged
merged 4 commits into from
Jun 25, 2021

Conversation

jmeg-sfy
Copy link
Contributor

Problem

What is being fixed? Examples:

  • WindowCovering Cluster is outdated and date from ZCL
  • Define New Attributes and Commands required for Test Event
  • Rename Attributes and Commands accordingly with the Specs

Change overview

This is the first part of a multiple series of PRs to update the examples for Window Covering in order to simplify code reviews

  • Update the Window Covering cluster definitions following the last Specifications
  • Update definition and renaming some functions into EFR32 Window Covering example

Testing

How was this tested? (at least one bullet point required)

  • Tested via chip-device-ctrl driving the EFR32 window-app example

@woody-apple
Copy link
Contributor

@github-actions
Copy link

Size increase report for "gn_qpg6100-example-build" from 2f0c691

File Section File VM
chip-qpg6100-lighting-example.out .text -40 -40
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_loc,0,200
[Unmapped],0,40
.debug_info,0,21
.debug_line,0,17
.debug_str,0,2
.text,-40,-40


@mspang mspang merged commit e013877 into project-chip:master Jun 25, 2021
@jmeg-sfy jmeg-sfy deleted the jmeg-sfy/window-covering-part-11 branch July 26, 2021 08:51
nikita-s-wrk pushed a commit to nikita-s-wrk/connectedhomeip that referenced this pull request Sep 23, 2021
* WC: Update WindowCovering with updated xml

* WC: Update scene for compilation + Add missing callback

* Restyled by clang-format

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Michael Spang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants