Remove lwIP from src/inet deps in socket builds #7785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcarmelveilleux
approved these changes
Jun 21, 2021
Damian-Nordic
approved these changes
Jun 21, 2021
We're getting a bunch of lwIP #defines in Linux builds, even though these builds don't use lwIP. Fix the src/inet dependency to check chip_system_config_use_lwip, which controls whether CHIP uses lwIP in its networking abstractions. This requires annotating some conditional #includes with // nogncheck because the checker doesn't preprocess the file.
mspang
force-pushed
the
for-chip/remove-lwip-dep
branch
from
f685144 to
b495419
Compare
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
gerickson,
hawk248,
jepenven-silabs,
msandstedt and
vivien-apple
msandstedt
approved these changes
Jun 21, 2021
andy31415
approved these changes
Jun 21, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
We're getting a bunch of lwIP #defines in Linux builds, even though these builds don't use lwIP. Fix the src/inet dependency to check chip_system_config_use_lwip, which controls whether CHIP uses lwIP in its networking abstractions. This requires annotating some conditional #includes with // nogncheck because the checker doesn't preprocess the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We're getting a bunch of lwIP #defines in Linux builds, even though
these builds don't use lwIP.
Change overview
Fix the src/inet dependency to check
chip_system_config_use_lwip,which controls whether CHIP uses lwIP in its networking abstractions.
This requires annotating some conditional #includes with
// nogncheckto avoid false positives, because the checker doesn't preprocess the file.
Testing
Check defines via
gn gen out/host && gn desc out/host //src/lib definesRun build via
./gn_build.sh