Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Add initial IM write client/handler[TE4] #7755

Closed
wants to merge 2 commits into from

Conversation

restyled-io[bot]
Copy link
Contributor

@restyled-io restyled-io bot commented Jun 18, 2021

A duplicate of #7730 with additional commits that automatically address
incorrect style, created by Restyled.

⚠️ Even though this PR is not a Fork, it contains outside contributions.
Please review accordingly.

Since the original Pull Request was opened as a fork in a contributor's
repository, we are unable to create a Pull Request branching from it with only
the style fixes.

The following Restylers made fixes:

To incorporate these changes, you can either:

  1. Merge this Pull Request instead of the original, or

  2. Ask your contributor to locally incorporate these commits and push them to
    the original Pull Request

    Expand for example instructions
    ```console
    git remote add upstream https://github.com/project-chip/connectedhomeip.git
    git fetch upstream pull/<this PR number>/head
    git merge --ff-only FETCH_HEAD
    git push
    ```
    

NOTE: As work continues on the original Pull Request, this process will
re-run and update (force-push) this Pull Request with updated style fixes as
necessary. If the style is fixed manually at any point (i.e. this process finds
no fixes to make), this Pull Request will be closed automatically.

Sorry if this was unexpected. To disable it, see our documentation.

@restyled-io restyled-io bot added the restyled label Jun 18, 2021
@todo
Copy link

todo bot commented Jun 18, 2021

Add attribute version support

// TODO: Add attribute version support
attributeDataElement.DataVersion(0);
attributeDataElement.EndOfAttributeDataElement();
SuccessOrExit(err = attributeDataElement.GetError());
MoveToState(State::AddAttribute);
exit:
ChipLogFunctError(err);
return err;
}


This comment was generated by todo based on a TODO comment in 9294de0 in #7755. cc @project-chip.

@boring-cyborg boring-cyborg bot added the app label Jun 18, 2021
@todo
Copy link

todo bot commented Jun 18, 2021

temprary create a SecureSessionHandle from node id, will be fix in PR 3602

// TODO: temprary create a SecureSessionHandle from node id, will be fix in PR 3602
// TODO: Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451
if (apSecureSession == nullptr)
{
mpExchangeCtx = mpExchangeMgr->NewContext({ aNodeId, 0, aAdminId }, this);
}
else
{
mpExchangeCtx = mpExchangeMgr->NewContext(*apSecureSession, this);
}
VerifyOrExit(mpExchangeCtx != nullptr, err = CHIP_ERROR_NO_MEMORY);


This comment was generated by todo based on a TODO comment in 9294de0 in #7755. cc @project-chip.

@todo
Copy link

todo bot commented Jun 18, 2021

Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451

// TODO: Hard code keyID to 0 to unblock IM end-to-end test. Complete solution is tracked in issue:4451
if (apSecureSession == nullptr)
{
mpExchangeCtx = mpExchangeMgr->NewContext({ aNodeId, 0, aAdminId }, this);
}
else
{
mpExchangeCtx = mpExchangeMgr->NewContext(*apSecureSession, this);
}
VerifyOrExit(mpExchangeCtx != nullptr, err = CHIP_ERROR_NO_MEMORY);
mpExchangeCtx->SetResponseTimeout(kImMessageTimeoutMsec);


This comment was generated by todo based on a TODO comment in 9294de0 in #7755. cc @project-chip.

@restyled-io restyled-io bot closed this Jun 18, 2021
@restyled-io restyled-io bot deleted the restyled/pull-7730 branch June 18, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants