-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tests] Add tests to TestCluster.yaml for unsupported attributes, long octet string and lists. #7741
Merged
woody-apple
merged 6 commits into
project-chip:master
from
vivien-apple:Tests_AddLongOctetStringAndUnsupportedAttribute
Jun 19, 2021
Merged
[Tests] Add tests to TestCluster.yaml for unsupported attributes, long octet string and lists. #7741
woody-apple
merged 6 commits into
project-chip:master
from
vivien-apple:Tests_AddLongOctetStringAndUnsupportedAttribute
Jun 19, 2021
+1,719
−761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-src.zapt template to put the right size when writing an attribute
…ported on the server side
pullapprove
bot
requested review from
andy31415,
bzbarsky-apple,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
pan-apple
June 18, 2021 08:16
Size increase report for "esp32-example-build" from 01ee80e
Full report output
|
Size increase report for "nrfconnect-example-build" from 01ee80e
Full report output
|
andy31415
approved these changes
Jun 18, 2021
msandstedt
approved these changes
Jun 18, 2021
woody-apple
approved these changes
Jun 19, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
…g octet string and lists. (project-chip#7741) * Update src/app/util to not use uint8_t for emAfSend and update encoder-src.zapt template to put the right size when writing an attribute * Add LONG_OCTET_STRING to TestCluster and an attribute that is not supported on the server side * Add a test for unsupported attributes and a test for LONG_OCTET_STRING * Update templates and src/app/clusters/test-cluster-server * Add an helper for c++ literal suffix * Update gen/ folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently there is no tests for unsupported attributes, not long octet string. And the current tests for attributes of type
List
does not check the content, just that the return status is a success.That's an issue since #7634 was sort of green, but there were issues for all those.
Change overview
List
attributes when they are returnedLONG_OCTET_STRING
src/app/util
since it was truncating the response to a max size ofuint8_t
encoder-src.zapt
since it was not putting the right size when writing attribute with a size > uint8_t.src/app/clusters/test-cluster-server/
to write some content for theLIST
attributeTesting
src/app/tests/suites/TestCluster.yaml