Disallow copy-construction of Device objects. #7719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lifetime of these objects is entirely managed by DeviceController and copy-constructing them does not make any sense.
pullapprove
bot
requested review from
andy31415,
chrisdecenzo,
Damian-Nordic,
hawk248,
jepenven-silabs,
msandstedt and
woody-apple
woody-apple
approved these changes
Jun 17, 2021
msandstedt
approved these changes
Jun 17, 2021
Damian-Nordic
approved these changes
Jun 18, 2021
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
The lifetime of these objects is entirely managed by DeviceController and copy-constructing them does not make any sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lifetime of these objects is entirely managed by DeviceController
and copy-constructing them does not make any sense.
Problem
If someone copies a Device, as @msandstedt noted, they can end up having it outlive the objects its members point to, and then bad things will happen.
Change overview
Disallow copying Device, because that's not a thing that makes sense.
Testing
Manual testing that attempting to copy fails. We don't really have a way to test "this should not compile" yet...