Fix concurrency grouping to allow multiple parallel manual dispatches of a job. #7689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of a job. 1) Adds concurrency bits to a few workflows that did not have them but should. 2) Fixes concurrency grouping for "workflow_dispatch" to use the run number (which is unique for each dispatch for a given (repo, workflow) pair) so that a new manual dispatch does not cancel a previously-running one. This allows doing multiple manual dispatches to try to reproduce intermittent issues.
pullapprove
bot
requested review from
chrisdecenzo,
jelderton,
jmartinez-silabs,
LuDuda,
mspang and
saurabhst
|
For review purposes, most of this PR was generated with: |
woody-apple
approved these changes
Jun 16, 2021
|
@msandstedt @saurabhst @andy31415 @mspang @jmartinez-silabs @LuDuda Please take a look? |
saurabhst
approved these changes
Jun 16, 2021
jmartinez-silabs
approved these changes
Jun 16, 2021
sharadb-amazon
pushed a commit
to sharadb-amazon/connectedhomeip
that referenced
this pull request
Jun 17, 2021
… of a job. (project-chip#7689) 1) Adds concurrency bits to a few workflows that did not have them but should. 2) Fixes concurrency grouping for "workflow_dispatch" to use the run number (which is unique for each dispatch for a given (repo, workflow) pair) so that a new manual dispatch does not cancel a previously-running one. This allows doing multiple manual dispatches to try to reproduce intermittent issues.
nikita-s-wrk
pushed a commit
to nikita-s-wrk/connectedhomeip
that referenced
this pull request
Sep 23, 2021
… of a job. (project-chip#7689) 1) Adds concurrency bits to a few workflows that did not have them but should. 2) Fixes concurrency grouping for "workflow_dispatch" to use the run number (which is unique for each dispatch for a given (repo, workflow) pair) so that a new manual dispatch does not cancel a previously-running one. This allows doing multiple manual dispatches to try to reproduce intermittent issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds concurrency bits to a few workflows that did not have them but should.
Fixes concurrency grouping for "workflow_dispatch" to use the run
number (which is unique for each dispatch for a given (repo, workflow)
pair) so that a new manual dispatch does not cancel a
previously-running one. This allows doing multiple manual dispatches
to try to reproduce intermittent issues.
Problem
Trying to manually dispatch multiple copies of a workflow ends up canceling all but the latest dispatch, since they all have the same sha.
Change overview
Use the run number as the grouping for the "workflow_dispatch" trigger.
Testing
Manually dispatches some workflows and they all ran.